Project

General

Profile

Actions

Bug #11437

closed

"Can't modify frozen Array" error on frozen arrays in select list

Added by Shlomi Zadok over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Detected when used with Date::DAYNAMES which is locked since ruby 1.8.6

Since #9591 with commit, select_f method is adding the include_blank option on top of the array.

If the array is locked, this will raise "Can't modify frozen Array" error


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #9591: Override puppet configuration on host level does not work if specified on host groupClosedShimon Shtein03/01/2015Actions
Actions #1

Updated by Dominic Cleal over 8 years ago

What does this impact precisely? Is it a plugin? I can't see any use of Date::DAYNAMES in Foreman.

Actions #2

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #9591: Override puppet configuration on host level does not work if specified on host group added
Actions #3

Updated by Shimon Shtein over 8 years ago

  • Assignee set to Shimon Shtein
Actions #4

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2625 added
  • Pull request deleted ()
Actions #5

Updated by Shlomi Zadok over 8 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Shimon Shtein)
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2625)

It impacts a plugin (though a workaround has been applied), yet it may affect also Foreman core if we'd ever use a frozen array

Actions #6

Updated by Shlomi Zadok over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Shimon Shtein
  • Pull request https://github.com/theforeman/foreman/pull/2625 added
  • Pull request deleted ()
Actions #7

Updated by Dominic Cleal over 8 years ago

  • Category set to Web Interface
  • translation missing: en.field_release set to 72
Actions #8

Updated by Ondřej Pražák over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #9

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release changed from 72 to 63

n/a to 1.9.

Actions

Also available in: Atom PDF