Project

General

Profile

Actions

Bug #12059

closed

AuthSource allow_nil for hosts should be removed

Added by Daniel Lobato Garcia over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When we migrated to the new migration syntax, the clause 'validate_length_of :host' was wrongly translated. It contains a clause 'allow_nil' that allows it to be nil, but in Rails 3 the :presence => true clause takes precedence. If you try to run AuthSourceLdap.new(:host => nil) it will fail as it need a host (correctly). This clause has to be removed so that Rails 4 doesn't allow to create AuthSourceLdap without a host, as :allow_nil takes precedence in Rails 4.

Actions #1

Updated by Daniel Lobato Garcia over 8 years ago

  • Subject changed from AuthSource allow_nil should apply to length only to AuthSource allow_nil for hosts should be removed
Actions #2

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2779 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal over 8 years ago

  • Assignee set to Daniel Lobato Garcia
  • translation missing: en.field_release set to 71
Actions #4

Updated by Daniel Lobato Garcia over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF