Project

General

Profile

Actions

Bug #12065

closed

Refresh host tab in job invocation detail together with overall status

Added by Ohad Levy over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

when reviewing a job status, I could see multiple requests in the same second for refresh.

this is caused due to how the refresh is triggered (every time you get a response from the server, you immediately start to ask for another refresh).

IMHO this logic should be extracted from the rails response code, and managed once within the initial js that is loaded.

related, the host tab is not updated, and requires a manual update.


Related issues 1 (0 open1 closed)

Blocks Foreman Remote Execution - Feature #11865: Job invocation results host list improvementsClosedMarek Hulán09/17/2015Actions
Actions #1

Updated by Marek Hulán over 8 years ago

I don't follow, with every response there's 1 second timeout so next refresh is in interval = (response time + 1 second). If the refresh is triggered more frequently, it might be bug in JS but not caused by the fact that JS is sent in response?

Actions #2

Updated by Ohad Levy over 8 years ago

Yes you are right, was reading it wrong.

then in this case, we can convert this issue to the host tab not updating? (maybe we can update it on click vs in the background)? and refresh it if its active?

Actions #3

Updated by Marek Hulán over 8 years ago

  • Subject changed from job review refresh interval is too high to Refresh host tab in job invocation detail together with overall status
  • Status changed from New to Assigned
  • Assignee set to Marek Hulán
  • Target version set to 87

I think it will be more efficient to do the update together in same request for which we do the chart update. We won't refresh the whole table, just hosts that hasn't finish the run yet. Otherwise we'd have to deal with pagination, also is user would select some text it would remove the selection etc...

Actions #4

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/52 added
  • Pull request deleted ()
Actions #5

Updated by Marek Hulán over 8 years ago

  • Blocks Feature #11865: Job invocation results host list improvements added
Actions #6

Updated by Marek Hulán over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
  • translation missing: en.field_release set to 99
Actions #7

Updated by Ivan Necas over 8 years ago

  • translation missing: en.field_release changed from 99 to 101
Actions

Also available in: Atom PDF