Project

General

Profile

Actions
Copy link

Refactor #12067

closed

Delegated methods need to be public, not protected

Added by Daniel Lobato Garcia over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Rails
Target version:
1.10.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2781
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

generate_pxe_template and require_ip_validation? are delegated to primary interface on Host::Managed. However, these methods are protected. On Rails 4, protected methods cannot be called through a delegation, these methods have to be public.

Actions
Copy link
 #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2781 added
  • Pull request deleted ()
Actions
Copy link
 #2

Updated by Dominic Cleal over 8 years ago

  • Tracker changed from Bug to Refactor
  • Assignee set to Daniel Lobato Garcia
  • translation missing: en.field_release set to 63
Actions
Copy link
 #3

Updated by Daniel Lobato Garcia over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF