Project

General

Profile

Actions

Refactor #12822

open

Separate LookupValue to different classes per LookupKey type

Added by Ori Rabin over 8 years ago. Updated over 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Parameters
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

As suggested by: https://github.com/theforeman/foreman/pull/2909#discussion_r46676200
LookupKey has been separated into two classes and LookupValue still has specific logic for each one.
LookupValue should also be separated or at least move the puppet specific logic into a child class.


Related issues 4 (1 open3 closed)

Related to Foreman - Refactor #10832: Make LookupKey an STI for puppet and variable keysClosedTom Caspy06/16/2015Actions
Related to Foreman - Refactor #15828: Turn default value in lookup key to a lookup valueNewActions
Related to Foreman - Refactor #15846: Rename use_puppet_default in lookup values to skip_foremanClosedShimon Shtein07/27/2016Actions
Has duplicate Foreman - Refactor #15710: Create STI for LookupValuesDuplicate07/17/2016Actions
Actions #1

Updated by Dominic Cleal over 8 years ago

  • Related to Refactor #10832: Make LookupKey an STI for puppet and variable keys added
Actions #2

Updated by Ori Rabin over 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Amir Fefer
Actions #3

Updated by Dominic Cleal about 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3080 added
Actions #4

Updated by Dominic Cleal over 7 years ago

Actions #5

Updated by Ori Rabin over 7 years ago

  • Related to Refactor #15828: Turn default value in lookup key to a lookup value added
Actions #6

Updated by Ivan Necas over 7 years ago

  • Target version set to 113
Actions #7

Updated by Ivan Necas over 7 years ago

  • Target version deleted (113)
Actions #8

Updated by Shimon Shtein over 7 years ago

At least from Puppet separation point of view, we can handle the LookupValue without inheritance.
All we need to do, is rename use_puppet_default to something more generic.
I have already opened an issue for that: [[http://projects.theforeman.org/issues/15846]]

Actions #9

Updated by Shimon Shtein over 7 years ago

  • Related to Refactor #15846: Rename use_puppet_default in lookup values to skip_foreman added
Actions #10

Updated by Dominic Cleal over 7 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Amir Fefer)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3080)

No activity on PR after being put up for review.

Actions

Also available in: Atom PDF