Bug #1283

Stray comma in highcharts code breaks IE

Added by Jacob McCann over 1 year ago. Updated over 1 year ago.

Status:Closed Start:11/01/2011
Priority:Normal Due date:
Assigned to:Amos Benari % Done:

100%
Category:Web Interface
Target version:0.4
Backlog:No Difficulity:
Votes: 0

Description

Our corporate standard browser is IE6 (ick). I've tested foreman in IE6 and IE7 and the charts do not work. I checked the highcharts site and it states that IE6 and IE7 are compatible browsers.

I found a stray comma that was breaking the js in IE.

For foreman 0.3 in file app/helpers/statistics_helper.rb:

      credits: {
      enabled: false,
      },

Is modified by removing the comma after 'false' (and I added some whitespace, but that isn't needed):

      credits: {
        enabled: false
      },

I was going to try and edit and patch this myself to submit, but then noticed foreman 0.4 changes this quite a bit. I'll keep looking to see if I can patch 0.4, but someone more familiar might be able to do this in 30 seconds. :P Or maybe its not even broke in 0.4?

History

Updated by Ohad Levy over 1 year ago

  • Category set to Web Interface
  • Assigned to set to Amos Benari
  • Target version set to 0.4

Updated by Jacob McCann over 1 year ago

Similar updates needed in the following (for 0.3):

app/helpers/dashboard_helper.rb (for methods render_overview and render_run_distribution)
app/helpers/hosts_helper.rb (render_report_status_chart, render_runtime_chart)

Not sure how helpful this is since its changed in 0.4, but I'll keep updating if I find/fix more on my deployment. :)

Updated by Amos Benari over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

was fixed as part of the none obtrusive javascript patch that is already applied.

Also available in: Atom PDF