Project

General

Profile

Actions

Bug #12925

open

Need to break up Repository model to smaller size

Added by Partha Aji over 8 years ago. Updated almost 6 years ago.

Status:
Ready For Testing
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Repository model is close to breaking the max class length rubo cop limit.

According to our rubocop metrics, max length per class is 500 lines. Repository.rb is very close to crossing that.
https://github.com/Katello/katello/blob/master/app/models/katello/repository.rb

One approach is to split functionality to different modules and include it in the main model.

Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5685 added
Actions #2

Updated by Eric Helms over 8 years ago

  • translation missing: en.field_release set to 114
Actions #3

Updated by Partha Aji about 8 years ago

So the suggestion for this is to use Single Table Inheritance.
Remove the rubocop class length directive.

Actions

Also available in: Atom PDF