Project

General

Profile

Actions

Tracker #15715

closed

Rails 5.0 upgrade tasks

Added by Dominic Cleal over 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
-
% Done:

0%

Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Track tasks to upgrade Foreman to support Rails 5.0.


Related issues 47 (2 open45 closed)

Related to Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed09/16/2017

Actions
Related to Foreman - Refactor #20956: Passing a class as a value in an Active Record query is deprecatedClosed09/16/2017Actions
Related to Foreman - Refactor #20960: Use activerecord-session_store with Rails 5.1 compatibility Closed09/16/2017Actions
Related to Foreman - Refactor #20961: Turbolinks Classic is not Rails 5.1 compatibleClosed09/16/2017Actions
Related to Discovery - Bug #20970: Discovery via fact import is broken for rails 5ClosedTomer Brisker09/17/2017Actions
Related to Discovery - Bug #20971: *_filter should be replaced with *_action for rails 5 compatClosedTomer Brisker09/17/2017Actions
Related to Foreman - Refactor #21084: Always use Rails 5.0, Drop Rails 4.2Closed09/23/2017Actions
Related to Foreman - Refactor #21097: remove settings deprecated by Rails 5.0Closed09/25/2017Actions
Related to Foreman - Refactor #21098: Update functional test request positional args to keywords Closed09/25/2017Actions
Related to Foreman - Refactor #21099: Replace redirect_to :back with redirect_back Closed09/25/2017Actions
Related to Foreman - Refactor #21100: Explicitly set DB migration compatibility to 4.2Closed09/25/2017Actions
Related to Foreman - Refactor #21101: Pass 'parameterize' separator as kwarg Closed09/25/2017Actions
Related to Foreman - Refactor #21102: Replace 'xhr' in tests with keyword argumentClosed09/25/2017Actions
Related to Foreman - Refactor #21103: Replace 'false' AR callback results with explicit throwClosed09/25/2017Actions
Related to Discovery - Refactor #21153: Passing conditions to destroy_all is deprecatedClosed09/28/2017Actions
Related to Foreman Remote Execution - Refactor #21216: fix Rails 5.x deprecations that are still compatible with Rails 4.2Closed10/05/2017Actions
Related to Discovery - Bug #21244: Remaining Rails 5 ugprade problems in discoveryClosedLukas Zapletal10/09/2017Actions
Related to Foreman - Bug #21553: Application doesn't start when using Rails 5 DEBsClosed11/01/2017Actions
Related to Foreman - Bug #21564: OAuth i.e. for proxy registration doesn't work with Rails 5Closed11/02/2017Actions
Related to Foreman - Refactor #7570: set secret_key_base for rails 6.0 upgradeClosedTomer BriskerActions
Related to Foreman - Refactor #21902: Replace use_transactional_fixtures settingClosed12/07/2017Actions
Related to Katello - Bug #20317: Rails 5 compatibilityClosedDaniel Lobato Garcia07/17/2017Actions
Related to Foreman - Refactor #22152: upgrade record_tag_helperResolvedTomer BriskerActions
Related to Foreman - Refactor #22153: move away from rails-controller-testingNew01/04/2018Actions
Related to Foreman - Refactor #24934: Rails 5.x default configuration migrationsNewActions
Blocked by Foreman - Tracker #13243: Rails 4.2 upgrade tasksResolved01/15/2016

Actions
Blocked by Foreman - Feature #3917: Add strong_parameters to foremanClosedDominic Cleal12/19/2013Actions
Blocked by Foreman - Refactor #15716: Update jquery-rails to 4.xRejected07/18/2016Actions
Blocked by Foreman - Refactor #15787: Update shoulda-matchers to 3.xClosedDominic Cleal07/22/2016Actions
Blocked by Foreman - Refactor #19035: Refactor TopbarSweeper to remove rails-observer dependencyClosedDominic Cleal03/27/2017Actions
Blocked by Foreman - Feature #19050: Add support for running under Ruby on Rails 5.0ClosedDominic Cleal03/28/2017Actions
Blocked by foreman-tasks - Feature #20756: Support ActiveJob Dynflow adapter for Rails5ClosedIvan Necas08/28/2017Actions
Blocked by Foreman - Bug #20920: Rails 5 causes error when server is trying to startClosedTomer Brisker09/14/2017Actions
Blocked by Foreman - Refactor #20949: Replace deprecated ActiveModel::Errors usageClosed09/16/2017Actions
Blocked by Foreman - Refactor #20950: change 'uniq' to 'distinct' in ActiveRecord findersClosed09/16/2017Actions
Blocked by Foreman - Refactor #20951: Replace render :text with :plainClosed09/16/2017Actions
Blocked by Foreman - Refactor #20952: Replace Hash-related methods called on AC::Parameters Closed09/16/2017Actions
Blocked by Foreman - Refactor #20953: Remove unnecessary argument to assert_nothing_raisedClosed09/16/2017Actions
Blocked by Foreman - Refactor #20954: Accessing mime types via constants is deprecatedClosed09/16/2017Actions
Blocked by Foreman - Refactor #20957: Replace alias_method_chain with Module prepend Closed09/16/2017Actions
Blocked by Foreman - Refactor #20958: Passing an argument to force an association to reload is deprecatedClosed09/16/2017Actions
Blocked by Foreman - Refactor #20959: Remove :status option on 'head' to positional argument Closed09/16/2017Actions
Blocked by Foreman Remote Execution - Bug #20254: REX tests fail to run with rails 5Resolved07/10/2017Actions
Blocked by Discovery - Bug #20972: STI issues with Host::Discovered on Rails 5Duplicate09/17/2017Actions
Blocked by Foreman Remote Execution - Bug #20427: REX doesnt start with rails 5ClosedAdam Ruzicka07/27/2017Actions
Blocked by foreman-tasks - Bug #20980: Tests are failing with rails 5ClosedAdam Ruzicka09/18/2017Actions
Blocked by OpenSCAP - Bug #21094: Tests broken on Rails 5.0ClosedMarek Hulán09/25/2017Actions
Actions #1

Updated by Dominic Cleal over 7 years ago

Actions #2

Updated by Dominic Cleal over 7 years ago

  • Blocked by Feature #3917: Add strong_parameters to foreman added
Actions #3

Updated by Dominic Cleal over 7 years ago

Actions #4

Updated by Ohad Levy over 7 years ago

I would love if we use this opportunity to move away to webpack assets vs rails asset pipeline.

Actions #5

Updated by Daniel Lobato Garcia over 7 years ago

We're trying to, but what does Rails 5 have to do with it?


Reply from Ohad Levy:

Many of the asset ge,s are not compliant with rails 5 (e.g. wrong dependencies in spec file etc).
if we move away from using those, we wouldn't care much which version of rails we are using (and really, there is little connection between client side assets and rails version).


(Edited by Dominic, the comment was incorrectly edited instead of being replied to.)

Actions #6

Updated by Anonymous over 7 years ago

As a general hint: Rails 5 needs Ruby >= 2.2.1

Actions #7

Updated by Dominic Cleal over 7 years ago

Actions #8

Updated by Dominic Cleal about 7 years ago

  • Blocked by Refactor #19035: Refactor TopbarSweeper to remove rails-observer dependency added
Actions #9

Updated by Dominic Cleal about 7 years ago

  • Blocked by Feature #19050: Add support for running under Ruby on Rails 5.0 added
Actions #10

Updated by Lukas Zapletal about 7 years ago

  • Related to Bug #13772: The orchestration code uses SQL logger added
Actions #11

Updated by Lukas Zapletal almost 7 years ago

  • Related to deleted (Bug #13772: The orchestration code uses SQL logger)
Actions #12

Updated by Anonymous over 6 years ago

  • Status changed from New to Closed
Actions #13

Updated by Tomer Brisker over 6 years ago

  • Status changed from Closed to New

Still not quite there, reopening.

Actions #14

Updated by Tomer Brisker over 6 years ago

  • Related to Feature #20756: Support ActiveJob Dynflow adapter for Rails5 added
Actions #15

Updated by Tomer Brisker over 6 years ago

  • Related to deleted (Feature #20756: Support ActiveJob Dynflow adapter for Rails5)
Actions #16

Updated by Tomer Brisker over 6 years ago

  • Blocked by Bug #20317: Rails 5 compatibility added
Actions #17

Updated by Tomer Brisker over 6 years ago

  • Blocked by Feature #20756: Support ActiveJob Dynflow adapter for Rails5 added
Actions #18

Updated by Tomer Brisker over 6 years ago

  • Blocked by Bug #20920: Rails 5 causes error when server is trying to start added
Actions #19

Updated by Anonymous over 6 years ago

Actions #20

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20949: Replace deprecated ActiveModel::Errors usage added
Actions #21

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20950: change 'uniq' to 'distinct' in ActiveRecord finders added
Actions #22

Updated by Anonymous over 6 years ago

Actions #23

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20952: Replace Hash-related methods called on AC::Parameters added
Actions #24

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20953: Remove unnecessary argument to assert_nothing_raised added
Actions #25

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20954: Accessing mime types via constants is deprecated added
Actions #26

Updated by Anonymous over 6 years ago

  • Related to Refactor #20956: Passing a class as a value in an Active Record query is deprecated added
Actions #27

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20957: Replace alias_method_chain with Module prepend added
Actions #28

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20958: Passing an argument to force an association to reload is deprecated added
Actions #29

Updated by Anonymous over 6 years ago

  • Blocked by Refactor #20959: Remove :status option on 'head' to positional argument added
Actions #30

Updated by Anonymous over 6 years ago

  • Related to Refactor #20960: Use activerecord-session_store with Rails 5.1 compatibility added
Actions #31

Updated by Anonymous over 6 years ago

  • Related to Refactor #20961: Turbolinks Classic is not Rails 5.1 compatible added
Actions #32

Updated by Tomer Brisker over 6 years ago

  • Related to Bug #20970: Discovery via fact import is broken for rails 5 added
Actions #33

Updated by Tomer Brisker over 6 years ago

  • Related to Bug #20971: *_filter should be replaced with *_action for rails 5 compat added
Actions #34

Updated by Tomer Brisker over 6 years ago

  • Blocked by Bug #20254: REX tests fail to run with rails 5 added
Actions #35

Updated by Tomer Brisker over 6 years ago

  • Blocked by Bug #20972: STI issues with Host::Discovered on Rails 5 added
Actions #36

Updated by Tomer Brisker over 6 years ago

  • Blocked by Bug #20427: REX doesnt start with rails 5 added
Actions #37

Updated by Adam Ruzicka over 6 years ago

  • Blocked by Bug #20980: Tests are failing with rails 5 added
Actions #38

Updated by Anonymous over 6 years ago

Actions #39

Updated by Marek Hulán over 6 years ago

  • Blocked by Bug #21094: Tests broken on Rails 5.0 added
Actions #40

Updated by Anonymous over 6 years ago

  • Related to Refactor #21097: remove settings deprecated by Rails 5.0 added
Actions #41

Updated by Anonymous over 6 years ago

  • Related to Refactor #21098: Update functional test request positional args to keywords added
Actions #42

Updated by Anonymous over 6 years ago

  • Related to Refactor #21099: Replace redirect_to :back with redirect_back added
Actions #43

Updated by Anonymous over 6 years ago

  • Related to Refactor #21100: Explicitly set DB migration compatibility to 4.2 added
Actions #44

Updated by Anonymous over 6 years ago

Actions #45

Updated by Anonymous over 6 years ago

  • Related to Refactor #21102: Replace 'xhr' in tests with keyword argument added
Actions #46

Updated by Anonymous over 6 years ago

  • Related to Refactor #21103: Replace 'false' AR callback results with explicit throw added
Actions #47

Updated by Anonymous over 6 years ago

  • Related to Refactor #21153: Passing conditions to destroy_all is deprecated added
Actions #48

Updated by Anonymous over 6 years ago

  • Related to Refactor #21216: fix Rails 5.x deprecations that are still compatible with Rails 4.2 added
Actions #49

Updated by Lukas Zapletal over 6 years ago

  • Related to Bug #21244: Remaining Rails 5 ugprade problems in discovery added
Actions #50

Updated by Ivan Necas over 6 years ago

  • Related to Refactor #21205: Replace alias_method_chain with Module prepend added
Actions #51

Updated by Ivan Necas over 6 years ago

  • Related to deleted (Refactor #21205: Replace alias_method_chain with Module prepend )
Actions #52

Updated by Anonymous over 6 years ago

  • Related to Bug #21553: Application doesn't start when using Rails 5 DEBs added
Actions #53

Updated by Anonymous over 6 years ago

  • Related to Bug #21564: OAuth i.e. for proxy registration doesn't work with Rails 5 added
Actions #54

Updated by Anonymous over 6 years ago

  • Related to Refactor #7570: set secret_key_base for rails 6.0 upgrade added
Actions #55

Updated by Anonymous over 6 years ago

  • Related to Refactor #21902: Replace use_transactional_fixtures setting added
Actions #56

Updated by Anonymous over 6 years ago

  • Blocked by deleted (Bug #20317: Rails 5 compatibility)
Actions #57

Updated by Anonymous over 6 years ago

  • Related to Bug #20317: Rails 5 compatibility added
Actions #58

Updated by Anonymous over 6 years ago

  • Status changed from New to Resolved

Rails 5.0 is in, further issues should connect to #20948 (Rails 5.1 upgrade)

Actions #59

Updated by Anonymous about 6 years ago

Actions #60

Updated by Anonymous about 6 years ago

  • Related to Refactor #22153: move away from rails-controller-testing added
Actions #61

Updated by Anonymous over 5 years ago

  • Related to Refactor #24934: Rails 5.x default configuration migrations added
Actions

Also available in: Atom PDF