Bug #16564

"Missing frozen string literal comment." rubocop violations on develop

Added by Dominic Cleal about 1 year ago. Updated about 1 year ago.

Status:Closed
Priority:Normal
Assigned To:Tomer Brisker
Category:Tests
Target version:Team Daniel - iteration 3
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3846
Story points-
Velocity based estimate-
Release1.14.0Release relationshipAuto

Description

All files are failing rubocop checks since #16491 with the following error:

app/models/host.rb:1:1: C: Missing frozen string literal comment.
module Host
^

The Style/FrozenStringLiteralComment cop should be disabled or fixed.

There are also failures in config/initializers/secure_headers.rb that aren't passing, probably from when the PR was merged onto develop without re-checking it passed on the previous commit.


Related issues

Related to Foreman - Bug #16491: upgrade rubocop to version 0.42 Closed 09/08/2016
Related to Katello - Bug #16676: "Missing frozen string literal comment." rubocop violations Closed 09/23/2016

Associated revisions

Revision e1c55843
Added by Tomer Brisker about 1 year ago

Fixes #16564 - Disable FrozenStringLiteralComment cop

Also fixes a failng cop in config/initializers/secure_headers.rb

History

#1 Updated by Dominic Cleal about 1 year ago

  • Related to Bug #16491: upgrade rubocop to version 0.42 added

#2 Updated by Tomer Brisker about 1 year ago

  • Status changed from New to Assigned
  • Assigned To set to Tomer Brisker

#3 Updated by The Foreman Bot about 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3846 added

#4 Updated by Anonymous about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal about 1 year ago

  • Release set to 1.14.0

#6 Updated by Daniel Lobato Garcia about 1 year ago

  • Target version set to Team Daniel - iteration 3

#7 Updated by David Davis about 1 year ago

  • Related to Bug #16676: "Missing frozen string literal comment." rubocop violations added

Also available in: Atom PDF