Refactor #16752

Extract template-related code from Host::Managed

Added by Daniel Lobato Garcia 9 months ago. Updated 4 months ago.

Status:Closed
Priority:Normal
Assigned To:Daniel Lobato Garcia
Category:Rails
Target version:Team Daniel - Iteration 9
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3905
Story points-
Velocity based estimate-
Release1.15.0Release relationshipAuto

Description

Host::Managed contains a lot of code related with determining the template that a host should have. Other Host objects such as Host::Discovered might need that logic, without becoming a Host::Managed. A solution for this would be to extract the methods that have to do with templates to a concern, and every Host class that wants to implement them, just includes that concern.


Related issues

Related to Foreman - Bug #18557: Image based provisioning broken New 02/18/2017

Associated revisions

Revision ec3360d9
Added by Daniel Lobato Garcia 5 months ago

Fixes #16752 - Extract template code from Host::Managed

Host::Managed contains a lot of code related with determining the
template that a host should have. Other Host objects such as
Host::Discovered might need that logic, without becoming a
Host::Managed.

This commit extracts that into Hostext::OperatingSystem so it can
be used on plugins.

History

#1 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3905 added

#2 Updated by Daniel Lobato Garcia 9 months ago

  • Target version set to Team Daniel - iteration 3

#3 Updated by Anonymous 5 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 5 months ago

  • Category set to Rails
  • Release set to 1.15.0

#5 Updated by Daniel Lobato Garcia 5 months ago

  • Target version changed from Team Daniel - iteration 3 to Team Brad - Iteration 11

#6 Updated by Brad Buckingham 4 months ago

  • Target version deleted (Team Brad - Iteration 11)

#7 Updated by Michael Moll 4 months ago

  • Related to Bug #18557: Image based provisioning broken added

#8 Updated by Daniel Lobato Garcia 4 months ago

  • Target version set to Team Daniel - Iteration 9

Also available in: Atom PDF