Project

General

Profile

Actions

Bug #16846

closed

Org create returns unclear message when trying to assign a non-existent subnet

Added by Adam Ruzicka over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1199604

Description of problem:

When testing bug #1183196, I inadvertently tried creating org, associating it with a subnet that did not exist. When this occurs, user gets an error message that seems to have nothing to do with the subnet.

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-7-20150303.0

How reproducible:

Steps to Reproduce:
1. Create capsules/smart proxiess; furthermore, create only one subnet. Or create zero, and modify hammer command below accordingly.
2. Attempt to create an org:
hammer organization create --description "eeee" --name "eeee" --smart-proxy-ids=2 --domain-ids 1 --subnet-ids 1,2
3. View results

Actual results:
[root@rhsm-qe-2 ~]# hammer organization create --description "eeee" --name "eeee" --smart-proxy-ids=2 --domain-ids 1 --subnet-ids 1,2
[Foreman] Username: admin
[Foreman] Password for admin:
Could not create the organization:
Resource organization not found by id ''

Expected results:

An error message that makes more sense -- "No subnet found for id '2'" or whatever

Additional info:


Related issues 3 (0 open3 closed)

Related to Foreman - Bug #16813: Confusing error message on association not found errorClosedMarek Hulán10/06/2016Actions
Related to Katello - Bug #18063: Org create returns unclear message when trying to assign a non-existent subnetClosedAmit Karsale01/13/2017Actions
Related to OpenSCAP - Bug #18501: Tests broken after recent change in coreClosedOndřej Pražák02/14/2017Actions
Actions #1

Updated by Dominic Cleal over 7 years ago

  • Is duplicate of Bug #16813: Confusing error message on association not found error added
Actions #2

Updated by Dominic Cleal over 7 years ago

  • Status changed from New to Duplicate

Those error messages are likely to be generated by the API, not Hammer. I think it's been fixed in #16813, please retest on develop.

Actions #3

Updated by Adam Ruzicka over 7 years ago

On latest foreman, hammer-cli and hammer-cli-foreman I'm still getting the same error:

$ hammer organization create --name foobar --subnet-ids=9999
Could not create the organization:
  Resource organization not found by id ''
Actions #4

Updated by Dominic Cleal over 7 years ago

  • Project changed from Hammer CLI to Foreman
  • Subject changed from Hammer: org create - unclear message when trying to assign a non-existent subnet to Org create returns unclear message when trying to assign a non-existent subnet
  • Category changed from Other commands to API
  • Status changed from Duplicate to New

Thanks for confirming. #16813 probably only fixed the *_name belongs_to extension (HasManyCommon), while the reverse relation depends on the *_ids collection setter behaviour, which always raises an AR::NotFound. The error handler may need improving for that exception.

Actions #5

Updated by Dominic Cleal over 7 years ago

  • Is duplicate of deleted (Bug #16813: Confusing error message on association not found error)
Actions #6

Updated by Dominic Cleal over 7 years ago

  • Related to Bug #16813: Confusing error message on association not found error added
Actions #7

Updated by Marek Hulán over 7 years ago

  • Target version set to 115
Actions #8

Updated by Amit Karsale over 7 years ago

here are we expecting a generic error message statement or error specific to a specific parameter wrongly passed,
as the current message is generic for any resource not found, maybe we can revise the error message from "no resource loaded" to something like "some of the attribute values are inappropriate." or should it be specific?

Actions #9

Updated by Marek Hulán over 7 years ago

I think we should be specific and say what attribute is wrong.

Actions #10

Updated by Amit Karsale about 7 years ago

  • Related to Bug #18063: Org create returns unclear message when trying to assign a non-existent subnet added
Actions #11

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4189 added
Actions #12

Updated by Amit Karsale about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #13

Updated by Amit Karsale about 7 years ago

  • Assignee set to Amit Karsale
  • Target version changed from 115 to 158
Actions #14

Updated by Dominic Cleal about 7 years ago

  • translation missing: en.field_release set to 209
Actions #15

Updated by Ondřej Pražák about 7 years ago

  • Related to Bug #18501: Tests broken after recent change in core added
Actions

Also available in: Atom PDF