Feature #17145

Candlepin 2.0: Add in rollback support for failed manifest imports and refreshes

Added by David Davis about 1 year ago. Updated 11 months ago.

Status:New
Priority:Normal
Assigned To:-
Category:Candlepin
Target version:Team Brad - Backlog
Difficulty: Pull request:
Bugzilla link:
Story points-
Velocity based estimate-
ReleaseKatello BacklogRelease relationshipAuto

Description

Before removing the old orchestration code, we had a way to rollback failed imports. See my PR here:

https://github.com/Katello/katello/pull/6414/files#diff-17c58a600ab07af9fd58f9c4ccb66be4L217

Dynflow didn't have this yet but there is a PR open to add support for rolling back actions:

https://github.com/Dynflow/dynflow/pull/194

Have the Owner::Import action rollback and call del_owner_import in Provider.


Related issues

Related to Katello - Feature #17027: CP 2.0: Phase 1: Enhance manifest import/refresh to suppo... New 10/19/2016

History

#1 Updated by David Davis about 1 year ago

  • Related to Feature #17027: CP 2.0: Phase 1: Enhance manifest import/refresh to support new candlepin async APIs added

#2 Updated by Eric Helms about 1 year ago

  • Release set to Katello Backlog

#3 Updated by David Davis about 1 year ago

I started working on this but there's a snag. The existing code checks for a length of 1 for imports:

https://git.io/vXRfa

But here's what I see for imports. It seems to contain all attempts so it's rarely going to have a length of 1:

https://gist.github.com/daviddavis/4650f5de122c45d65f54031c34613c10

Here's my code which is a WIP. It reproduces the existing [broken] behavior in Dynflow:

https://github.com/daviddavis/katello/commit/fd4d08cb3fba6c121ac6e9d66db9b018c599487e

#4 Updated by Brad Buckingham about 1 year ago

  • Target version changed from Team Brad - Iteration 5 to Team Brad - Iteration 6

#5 Updated by Brad Buckingham about 1 year ago

  • Target version changed from Team Brad - Iteration 6 to Team Brad - Iteration 7

#6 Updated by Brad Buckingham 12 months ago

  • Target version changed from Team Brad - Iteration 7 to Team Brad - Iteration 8

#7 Updated by David Davis 12 months ago

  • Assigned To deleted (David Davis)

#8 Updated by Brad Buckingham 11 months ago

  • Target version changed from Team Brad - Iteration 8 to Team Brad - Iteration 9

#9 Updated by Brad Buckingham 11 months ago

  • Target version changed from Team Brad - Iteration 9 to Team Brad - Backlog

Also available in: Atom PDF