Refactor #17571

The foreman tools js module could be refactored to take advantage of some ES6 features

Added by Tomer Brisker about 1 year ago. Updated about 1 year ago.

Status:Closed
Priority:Normal
Assigned To:Tomer Brisker
Category:Web Interface
Target version:Team Daniel - iteration 6
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4081
Story points-
Velocity based estimate-
Release1.14.0Release relationshipAuto

Associated revisions

Revision 9a082a8b
Added by Tomer Brisker about 1 year ago

Fixes #17571 - Refactor tfm.tools to use ES6 syntax

This also extracts the inherited user roles function to a sepereate
module, adds tests and refactors it. These changes also fix two other
issues:
1. a possible stored XSS in usergroup names,
2. tooltips on tables were broken (due to => syntax not changing `this`)

Revision 0bae8cc5
Added by Tomer Brisker about 1 year ago

Fixes #17571 - Refactor tfm.tools to use ES6 syntax

This also extracts the inherited user roles function to a sepereate
module, adds tests and refactors it. These changes also fix two other
issues:
1. a possible stored XSS in usergroup names,
2. tooltips on tables were broken (due to => syntax not changing `this`)
(cherry picked from commit 9a082a8bfe273e4659403d2886d934075ba72fa9)

History

#1 Updated by The Foreman Bot about 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4081 added

#2 Updated by Anonymous about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal about 1 year ago

  • Release set to 1.14.0

#4 Updated by Daniel Lobato Garcia about 1 year ago

  • Target version set to Team Daniel - iteration 6

Also available in: Atom PDF