Refactor #17972

Trends JS is overly complicated, form & helper are outdated and inefficient

Added by Tomer Brisker 4 months ago. Updated 2 months ago.

Status:Closed
Priority:Normal
Assigned To:Tomer Brisker
Category:Trends
Target version:Team Daniel - Iteration 9
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4184, https://github.com/theforeman/foreman/pull/4162
Story points-
Velocity based estimate-
Release1.15.0Release relationshipAuto

Description

JS code is way too complex, the form and its helpers are only used for new trends but still check if this is a new trend and are inefficient in general.


Related issues

Related to Foreman - Bug #18033: unable to create a new trend Rejected 01/11/2017

Associated revisions

Revision 1d7dcde3
Added by Tomer Brisker 4 months ago

Fixes #17972 - Simplify new trend form js and helpers

Migrated the js to webpack as well.

Revision 77110ce3
Added by Tomer Brisker 4 months ago

Refs #17972 - remove trends.js from assets initializer

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4162 added

#2 Updated by Anonymous 4 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal 4 months ago

  • Release set to 1.15.0

#4 Updated by Ohad Levy 4 months ago

  • Related to Bug #18033: unable to create a new trend added

#5 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4184 added

#6 Updated by Daniel Lobato Garcia 3 months ago

  • Target version set to Team Brad - Iteration 11

#7 Updated by Brad Buckingham 2 months ago

  • Target version deleted (Team Brad - Iteration 11)

#8 Updated by Daniel Lobato Garcia 2 months ago

  • Target version set to Team Daniel - Iteration 9

Also available in: Atom PDF