Bug #18298

Job template description format doesnt accept input field variables when invoked

Added by Ivan Necas 3 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Ivan Necas
Category:-
Target version:Foreman - Team Ivan Iteration 10
Difficulty: Pull request:https://github.com/theforeman/foreman_remote_execution/pull/225
Bugzilla link:1416425
Story points-
Velocity based estimate-

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1416425

Description of problem:
I´ve created a custom job template where I cloned the Package Action - SSH Default template to my own custom template.

As description I have MyJob %{label} and I have a input field named label in the template which I fill in with a descriptive label when I run the job.

The variable label is however not rendered when the job is invoked and all jobs are just called "MyJob ".

Associated revisions

Revision c9c11afc
Added by Ivan Necas 3 months ago

Fixes #18298 - fix description generation

Previous algorithm failed, when the order of inputs was different than
the order of values in the invocation - the new test were extended with
and example that failed before this patch

History

#1 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Ivan Necas
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/225 added

#2 Updated by Ivan Necas 3 months ago

  • Subject changed from Job template description format doesnt accept input field variables when invoked to Job template description format doesnt accept input field variables when invoked
  • Target version set to Team Ivan Iteration 10

#3 Updated by Ivan Necas 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF