Bug #18510

remote execution job schedule and details page does not handle search query returning 0 hosts too well

Added by Adam Ruzicka 3 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Adam Ruzicka
Category:Usability
Target version:Foreman - Team Ivan Iteration 11
Difficulty: Pull request:https://github.com/theforeman/foreman_remote_execution/pull/230
Bugzilla link:1417807
Story points-
Velocity based estimate-

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1417807

Description of problem:
With search query matching 0 hosts, remote execution job schedule page:

Preview keeps screen grayed, without preview window and [close] button at all, not error message shown

And details page (this is only for "Update Package - Katello SSH Default through SSH" template):

In "Preview for target", there is "Warning! error during rendering: undefined method 'operatingsystem' for NilClass::Jail (NilClass)" instead of some simple error message

These two pages does not handle search query returning 0 hosts too well

Version-Release number of selected component (if applicable):
satellite-6.2.6-2.0.el7sat.noarch

How reproducible:
always

Steps to Reproduce:
1. Schedule remote execution job Monitor -> Jobs -> [Run job] with host
search query "name ~ such_a_host_does_not_exists"
2. Click icon of "eye" to preview matching hosts
3. Also try to schedule with:
Job category: Katello
Job template: Update Package...
and check "Preview for target" section

Actual results:
On schedule page if you click on preview button, it grays the screen and there is no way back.
On details page it shows template rendering warning

Expected results:
Should be possible to close grayed page and instead of template rendering error there should be informative error message like "No host matches the search query"

Associated revisions

Revision 849f361c
Added by Adam Ruzicka 3 months ago

Fixes #18510 - Display warning when search query matches no host

History

#1 Updated by Adam Ruzicka 3 months ago

  • Category set to Usability
  • Target version set to Team Ivan backlog

#2 Updated by Adam Ruzicka 3 months ago

Getting preview of the hosts seems to work, rendering a template preview does not

#3 Updated by The Foreman Bot 3 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Adam Ruzicka
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/230 added

#4 Updated by Ivan Necas 3 months ago

  • Target version changed from Team Ivan backlog to Team Ivan Iteration 11

#5 Updated by Adam Ruzicka 3 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF