Bug #18799
closed
nsupdate outputs an invalid command when dns_key is an empty string
Description
From https://github.com/theforeman/puppet-foreman_proxy/issues/180
When using an empty string as dns_key the smart proxy outputs "nsupdate -k " which causes it to abort with an error. The following config should reproduce it.
--- :dns_key: ""
The correct solution is to assume the user intended not to provide a key and skip the parameter.
Updated by The Foreman Bot about 7 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/514 added
Updated by Anonymous about 7 years ago
I cannot reproduce this. There's a validator on 'dns_key' setting that prevents it from having invalid values: "Disabling all modules in the group ['dns_nsupdate', 'dns'] due to a failure in one of them: File at '' defined in 'dns_key' parameter doesn't exist or is unreadable".
Updated by Ewoud Kohl van Wijngaarden about 7 years ago
- Status changed from Ready For Testing to Rejected
Right, so this may be invalid now and the fix in puppet-foreman_proxy might be sufficient. If it has to be some valid path we can even validate that on our side.