Bug #18853

when acknowledging notification as read, there is no indication it is marked as read until next api call

Added by Ohad Levy 11 months ago. Updated 10 months ago.

Status:Closed
Priority:Normal
Assigned To:matan werbner
Category:Notifications
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4401
Story points-
Velocity based estimate-
Release1.15.0Release relationshipAuto

Description

When a user marks a notification as read, there is no visual indication it has been marked as read.
the only time the notification appears as read is until the next time the notification timer gets reload the data and then its marked as read.

additionally, I can multiple times try to set it as read (as the ui doesnt change I though the api call did not execute), in the logs you can see its being triggered multiple times:

 Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:47 +0000
 Processing by NotificationRecipientsController#update as JSON
   Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}}
 Completed 200 OK in 14ms (Views: 0.4ms | ActiveRecord: 2.5ms)
 Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:48 +0000
 Processing by NotificationRecipientsController#update as JSON
   Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}}
 Completed 200 OK in 14ms (Views: 0.4ms | ActiveRecord: 2.5ms)
 Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:48 +0000
 Processing by NotificationRecipientsController#update as JSON
   Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}}
 Completed 200 OK in 14ms (Views: 0.4ms | ActiveRecord: 2.5ms)
 Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:51 +0000
 Processing by NotificationRecipientsController#update as JSON
   Parameters: {"seen"=>true, "id"=>"1", "notification_recipient"=>{"seen"=>true}}
 Completed 200 OK in 14ms (Views: 0.5ms | ActiveRecord: 2.5ms)
 Started PUT "/notification_recipients/1" for 10.35.3.218 at 2017-03-09 12:52:51 +0000

Associated revisions

Revision a29d5438
Added by matan werbner 10 months ago

Fixes #18957,#18193,#18678,#18853 - notifications redux

Refactored notifications to work with redux, fixed
several UI related bugs, added tests.
flux is now unused, this is based on @gailsteiger's
previous work.

Revision e2b7102e
Added by matan werbner 9 months ago

Fixes #18957,#18193,#18678,#18853 - notifications redux

Refactored notifications to work with redux, fixed
several UI related bugs, added tests.
flux is now unused, this is based on @gailsteiger's
previous work.

History

#1 Updated by Liza Gilman 10 months ago

  • Assigned To set to Liza Gilman

#2 Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4379 added

#3 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4401 added

#4 Updated by Ohad Levy 10 months ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/4379)

#5 Updated by Ohad Levy 10 months ago

  • Assigned To changed from Liza Gilman to matan werbner

#6 Updated by matan werbner 10 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Ohad Levy 10 months ago

  • Release set to 1.15.0

Also available in: Atom PDF