Bug #19063

Regression: Package name incorrect after package upload

Added by Klaas D 7 months ago. Updated 4 months ago.

Status:Closed
Priority:High
Assigned To:Partha Aji
Category:Repositories
Target version:Team Tom - Iteration 16
Difficulty:easy Pull request:https://github.com/Katello/katello/pull/6813
Bugzilla link:
Story points-
Velocity based estimate-
ReleaseKatello 3.4.1Release relationshipAuto

Description

Hi,
I think this was introduced in katello 3.2 but I only noticed it recently. Uploading a package (through hammer) will display an incorrect name. However it seems the packages work fine inside the repository.

This example uses a custom rpm build by emc (backup tool) and signed by myself for our environment.

I upload the package like this:

# hammer repository upload-content --product "Product" --name "Repository" --organization ORG --path ./lgtoclnt-8.2.0.5-1.x86_64.rpm 
Successfully uploaded file 'lgtoclnt-8.2.0.5-1.x86_64.rpm'.

it then shows in GUI like this:
lgtoclnt-8.2.0.5-1.x86_64.rpm-8.2.0.5-1.x86_64 (see attached screenshot)

the package details:

# hammer package info --id 8c28a831-73d3-467d-9013-39bef5241d11
ID:            161109
Name:          lgtoclnt-8.2.0.5-1.x86_64.rpm
Version:       8.2.0.5
Architecture:  x86_64
Epoch:         0
Release:       1
Author:        
Filename:      lgtoclnt-8.2.0.5-1.x86_64.rpm
Build Host:    bluejay.lss.emc.com
Vendor:        EMC Software.
License:       commercial
Relative Path: lgtoclnt-8.2.0.5-1.x86_64.rpm
Description:   EMC NetWorker protects the critical business data of more than 10,000
enterprise customers worldwide by simplifying, centralizing, and automating
backup and recovery operations across Unix, Windows, Linux and NetWare platforms
in DAS, NAS, and SAN storage environments. Built upon an open, highly scalable
client-server architecture, NetWorker reduces management overhead by providing
"lights out" protection of storage assets in the largest corporate data centers
and the smallest satellite branch offices.

Workaround:
I can rename the file and upload the package like this:

hammer repository upload-content --product "Product" --name "Repository" --organization ORG --path ./lgtoclnt

and it will work as expected :)

Greetings
Klaas

package name error.png - lgtoclnt-8.2.0.5-1.x86_64.rpm-8.2.0.5-1.x86_64 (14.2 KB) Preview Klaas D, 03/29/2017 04:11 AM

Package%20name%20error

Related issues

Related to Katello - Bug #17489: Inconsistent Package Name when Uploading content into Rep... Closed 11/25/2016
Related to Katello - Bug #20252: Regresion bug : Upload packages appear with wrong names a... Feedback 07/10/2017

Associated revisions

Revision b6bab836
Added by Partha Aji 4 months ago

fixes #19063 - uploads packages with correct name

This commit fixes an issue with the package uploads
The prior logic includes the package name for yum repos
while excludes the name for file repos. What we intend to
happen is the reverse. We need to include the name for file
but exclude for yum since the name is derived from the metadata
for yum, puppet and other types.

This commit also contains a couple of unit tests to handle this.

History

#1 Updated by Justin Sherrill 7 months ago

What version of katello is this? This looks like a dupe of http://projects.theforeman.org/issues/17489, but that should have been resolved in 3.3.1

#2 Updated by Klaas D 7 months ago

I'm pretty sure I have tested this on 3.3.1, but let me double check at work tomorrow :)

#3 Updated by Klaas D 7 months ago

Hi,
I tested it on 3.3.1

Installed Packages:

candlepin-0.9.54.10-1.el7.noarch
candlepin-selinux-0.9.54.10-1.el7.noarch
foremanserver.tld-foreman-client-1.0-1.noarch
foremanserver.tld-foreman-proxy-1.0-1.noarch
foremanserver.tld-foreman-proxy-client-1.0-1.noarch
foremanserver.tld-qpid-broker-1.0-2.noarch
foremanserver.tld-qpid-client-cert-1.0-1.noarch
foremanserver.tld-qpid-router-client-1.0-1.noarch
foremanserver.tld-qpid-router-server-1.0-1.noarch
foreman-1.14.2-1.el7.noarch
foreman-compute-1.14.2-1.el7.noarch
foreman-debug-1.14.2-1.el7.noarch
foreman-installer-1.14.2-1.el7.noarch
foreman-installer-katello-3.3.1.4-1.el7.noarch
foreman-postgresql-1.14.2-1.el7.noarch
foreman-proxy-1.14.2-1.el7.noarch
foreman-release-1.14.2-1.el7.noarch
foreman-release-scl-3-1.el7.noarch
foreman-selinux-1.14.2-1.el7.noarch
foreman-vmware-1.14.2-1.el7.noarch
katello-3.3.1-1.el7.noarch
katello-agent-2.9.1-1.el7.noarch
katello-agent-fact-plugin-2.9.1-1.el7.noarch
katello-ca-consumer-foremanserver.tld-1.0-1.noarch
katello-certs-tools-2.4.0-1.el7.noarch
katello-client-bootstrap-1.2.2-1.el7.noarch
katello-common-3.3.1-1.el7.noarch
katello-debug-3.3.1-1.el7.noarch
katello-default-ca-1.0-1.noarch
katello-installer-base-3.3.1.4-1.el7.noarch
katello-repos-3.3.1-1.el7.noarch
katello-selinux-3.0.2-1.el7.noarch
katello-server-ca-1.0-1.noarch
katello-service-3.3.1-1.el7.noarch
pulp-admin-client-2.10.3-1.el7.noarch
pulp-client-1.0-1.noarch
pulp-docker-plugins-2.1.0-1.el7.noarch
pulp-katello-1.0.2-1.el7.noarch
pulp-puppet-plugins-2.10.3-1.el7.noarch
pulp-puppet-tools-2.10.3-1.el7.noarch
pulp-rpm-admin-extensions-2.10.3-1.el7.noarch
pulp-rpm-handlers-2.10.3-1.el7.noarch
pulp-rpm-plugins-2.10.3-1.el7.noarch
pulp-selinux-2.10.3-1.el7.noarch
pulp-server-2.10.3-1.el7.noarch
python-gofer-qpid-2.7.6-1.el7.noarch
python-isodate-0.5.0-4.pulp.el7.noarch
python-kombu-3.0.33-6.pulp.el7.noarch
python-pulp-agent-lib-2.10.3-1.el7.noarch
python-pulp-bindings-2.10.3-1.el7.noarch
python-pulp-client-lib-2.10.3-1.el7.noarch
python-pulp-common-2.10.3-1.el7.noarch
python-pulp-docker-common-2.1.0-1.el7.noarch
python-pulp-oid_validation-2.10.3-1.el7.noarch
python-pulp-puppet-common-2.10.3-1.el7.noarch
python-pulp-repoauth-2.10.3-1.el7.noarch
python-pulp-rpm-common-2.10.3-1.el7.noarch
python-pulp-streamer-2.10.3-1.el7.noarch
python-qpid-1.35.0-3.el7.noarch
python-qpid-proton-0.17.0-1.el7.x86_64
python-qpid-qmf-1.35.0-3.el7.x86_64
python-urllib3-1.10.2-2.katello.el7.noarch
qpid-cpp-client-1.35.0-3.el7.x86_64
qpid-cpp-client-devel-1.35.0-3.el7.x86_64
qpid-cpp-server-1.35.0-3.el7.x86_64
qpid-cpp-server-linearstore-1.35.0-3.el7.x86_64
qpid-dispatch-router-0.7.0-1.el7.x86_64
qpid-proton-c-0.17.0-1.el7.x86_64
qpid-qmf-1.35.0-3.el7.x86_64
qpid-tools-1.35.0-3.el7.noarch
rubygem-smart_proxy_pulp-1.3.0-1.el7.noarch
tfm-rubygem-activerecord-session_store-0.1.2-2.el7.noarch
tfm-rubygem-addressable-2.3.6-3.el7.noarch
tfm-rubygem-algebrick-0.7.3-4.el7.noarch
tfm-rubygem-ancestry-2.2.1-1.el7.noarch
tfm-rubygem-anemone-0.7.2-14.el7.noarch
tfm-rubygem-angular-rails-templates-0.1.2-5.el7.noarch
tfm-rubygem-apipie-bindings-0.0.18-1.el7.noarch
tfm-rubygem-apipie-params-0.0.5-1.el7.noarch
tfm-rubygem-apipie-rails-0.3.7-1.el7.noarch
tfm-rubygem-audited-4.2.0-1.el7.noarch
tfm-rubygem-audited-activerecord-4.2.0-2.el7.noarch
tfm-rubygem-awesome_print-1.7.0-1.el7.noarch
tfm-rubygem-bastion-4.2.2-1.fm1_14.el7.noarch
tfm-rubygem-bundler_ext-0.4.1-1.el7.noarch
tfm-rubygem-clamp-1.0.0-5.el7.noarch
tfm-rubygem-colorize-0.7.7-4.el7.noarch
tfm-rubygem-concurrent-ruby-edge-0.2.0-4.fm1_12.el7.noarch
tfm-rubygem-css_parser-1.3.7-1.el7.noarch
tfm-rubygem-daemons-1.2.3-3.el7.noarch
tfm-rubygem-deacon-1.0.0-1.el7.noarch
tfm-rubygem-deep_cloneable-2.2.2-1.el7.noarch
tfm-rubygem-deface-1.0.2-3.el7.noarch
tfm-rubygem-diffy-3.0.1-3.el7.noarch
tfm-rubygem-docker-api-1.28.0-2.el7.noarch
tfm-rubygem-domain_name-0.5.20160310-1.el7.noarch
tfm-rubygem-dynflow-0.8.17-1.fm1_14.el7.noarch
tfm-rubygem-excon-0.51.0-1.el7.noarch
tfm-rubygem-facter-2.4.0-3.el7.x86_64
tfm-rubygem-fast_gettext-1.1.0-1.el7.noarch
tfm-rubygem-fog-1.38.0-1.el7.noarch
tfm-rubygem-fog-aws-0.13.0-1.el7.noarch
tfm-rubygem-fog-core-1.42.0-1.el7.noarch
tfm-rubygem-fog-google-0.1.0-2.el7.noarch
tfm-rubygem-fog-json-1.0.2-4.el7.noarch
tfm-rubygem-fog-openstack-0.1.12-1.el7.noarch
tfm-rubygem-fog-rackspace-0.1.1-1.el7.noarch
tfm-rubygem-fog-vsphere-1.4.0-1.el7.noarch
tfm-rubygem-fog-xenserver-0.2.3-1.el7.noarch
tfm-rubygem-fog-xml-0.1.2-4.el7.noarch
tfm-rubygem-foreman-tasks-0.8.6-1.fm1_14.el7.noarch
tfm-rubygem-foreman-tasks-core-0.1.1-1.fm1_14.el7.noarch
tfm-rubygem-foreman_docker-3.0.0-1.fm1_13.el7.noarch
tfm-rubygem-foreman_hooks-0.3.13-1.fm1_14.el7.noarch
tfm-rubygem-foreman_remote_execution-1.2.2-1.fm1_14.el7.noarch
tfm-rubygem-foreman_remote_execution_core-1.0.2-1.fm1_14.el7.noarch
tfm-rubygem-foreman_templates-4.0.1-1.fm1_14.el7.noarch
tfm-rubygem-formatador-0.2.1-9.el7.noarch
tfm-rubygem-friendly_id-5.1.0-3.el7.noarch
tfm-rubygem-gettext_i18n_rails-1.2.1-3.el7.noarch
tfm-rubygem-git-1.2.5-7.el7.noarch
tfm-rubygem-hammer_cli-0.8.0-1.el7.noarch
tfm-rubygem-hammer_cli_foreman-0.8.0-1.el7.noarch
tfm-rubygem-hammer_cli_foreman_bootdisk-0.1.3-5.el7.noarch
tfm-rubygem-hammer_cli_foreman_docker-0.0.4-2.el7.noarch
tfm-rubygem-hammer_cli_foreman_tasks-0.0.10-2.fm1_12.el7.noarch
tfm-rubygem-hammer_cli_import-0.11.3-1.el7.noarch
tfm-rubygem-hammer_cli_katello-0.3.0-1.el7.noarch
tfm-rubygem-hashie-2.0.5-4.el7.noarch
tfm-rubygem-highline-1.6.21-5.el7.noarch
tfm-rubygem-http-cookie-1.0.2-1.el7.noarch
tfm-rubygem-ipaddress-0.8.0-9.el7.noarch
tfm-rubygem-jquery-ui-rails-4.1.2-5.el7.noarch
tfm-rubygem-katello-3.3.1.1-1.el7.noarch
tfm-rubygem-ldap_fluff-0.4.4-1.el7.noarch
tfm-rubygem-little-plugger-1.1.3-21.el7.noarch
tfm-rubygem-locale-2.0.9-11.el7.noarch
tfm-rubygem-logging-1.8.2-4.el7.noarch
tfm-rubygem-net-ldap-0.15.0-1.el7.noarch
tfm-rubygem-net-scp-1.1.0-6.el7.noarch
tfm-rubygem-net-ssh-3.0.2-2.el7.noarch
tfm-rubygem-netrc-0.7.7-7.el7.noarch
tfm-rubygem-oauth-0.4.7-8.el7.noarch
tfm-rubygem-parse-cron-0.1.4-2.fm1_11.el7.noarch
tfm-rubygem-passenger-4.0.18-9.11.el7.x86_64
tfm-rubygem-passenger-native-4.0.18-9.11.el7.x86_64
tfm-rubygem-passenger-native-libs-4.0.18-9.11.el7.x86_64
tfm-rubygem-pg-0.15.1-3.el7.x86_64
tfm-rubygem-powerbar-1.0.17-1.el7.noarch
tfm-rubygem-protected_attributes-1.1.3-3.el7.noarch
tfm-rubygem-qpid_messaging-0.34.1-1.el7.x86_64
tfm-rubygem-rabl-0.12.0-2.el7.noarch
tfm-rubygem-rack-jsonp-1.3.1-5.el7.noarch
tfm-rubygem-rails-i18n-4.0.9-1.el7.noarch
tfm-rubygem-rails-observers-0.1.2-7.el7.noarch
tfm-rubygem-rbvmomi-1.9.4-1.el7.noarch
tfm-rubygem-responders-2.3.0-1.el7.noarch
tfm-rubygem-rest-client-1.8.0-1.el7.noarch
tfm-rubygem-roadie-3.1.1-1.el7.noarch
tfm-rubygem-roadie-rails-1.1.1-1.el7.noarch
tfm-rubygem-robotex-1.0.0-19.el7.noarch
tfm-rubygem-ruby2ruby-2.1.3-4.el7.noarch
tfm-rubygem-ruby_parser-3.6.3-4.el7.noarch
tfm-rubygem-runcible-1.9.1-1.el7.noarch
tfm-rubygem-safemode-1.2.4-2.el7.noarch
tfm-rubygem-scoped_search-3.3.0-1.el7.noarch
tfm-rubygem-secure_headers-3.4.1-1.el7.noarch
tfm-rubygem-sequel-4.20.0-5.el7.noarch
tfm-rubygem-sexp_processor-4.4.4-3.el7.noarch
tfm-rubygem-smart_proxy_dynflow_core-0.1.5-1.fm1_14.el7.noarch
tfm-rubygem-table_print-1.5.1-6.el7.noarch
tfm-rubygem-trollop-2.1.2-1.el7.noarch
tfm-rubygem-unf-0.1.3-5.el7.noarch
tfm-rubygem-unf_ext-0.0.6-6.el7.x86_64
tfm-rubygem-useragent-0.16.8-1.el7.noarch
tfm-rubygem-validates_lengths_from_database-0.5.0-3.el7.noarch
tfm-rubygem-webpack-rails-0.9.8-1.el7.noarch
tfm-rubygem-wicked-1.1.0-4.el7.noarch
tfm-rubygem-will_paginate-3.1.5-1.el7.noarch
tfm-rubygem-x-editable-rails-1.5.5-1.el7.noarch
tfm-runtime-3.2-5.el7.x86_64

#4 Updated by Klaas D 7 months ago

  • Related to Bug #17489: Inconsistent Package Name when Uploading content into Repository via Web UI and Hammer CLI added

#5 Updated by Eric Helms 7 months ago

  • Status changed from New to Need more information
  • Release set to Katello 3.3.2

Klass -- retesting it on 3.3.1 are you saying it still failed for you?

#6 Updated by Klaas D 7 months ago

  • Status changed from Need more information to New

Yes Eric, still failing on 3.3.1

#7 Updated by Justin Sherrill 5 months ago

  • Release changed from Katello 3.3.2 to Katello 3.4.1

#8 Updated by Justin Sherrill 5 months ago

  • Assigned To set to Partha Aji
  • Target version set to Team Tom - Iteration 13
  • Difficulty set to easy

#9 Updated by Thomas McKay 5 months ago

  • Target version changed from Team Tom - Iteration 13 to Team Tom - Iteration 16

#10 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6813 added

#11 Updated by Eric Helms 4 months ago

  • Priority changed from Normal to High

#12 Updated by Partha Aji 4 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#13 Updated by Mario Gamboa 3 months ago

  • Related to Bug #20252: Regresion bug : Upload packages appear with wrong names adding version after rpm name added

Also available in: Atom PDF