Project

General

Profile

Actions

Bug #20311

closed

Notification drawer fuctionality does not seem to be appropriate.

Added by Rahul Bajaj over 6 years ago. Updated over 6 years ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

1) If the notification drawer is open and you forget to close it, it remains open even if you browse to some other page.
2) Notification drawer has a weird placement, as in its far from its icon(i am not sure why that is happening).
3) Notification drawer does not follow the pattern fly standards.


Files

notification_drawer.png View notification_drawer.png 65.5 KB Rahul Bajaj, 07/15/2017 06:37 AM
drawer.png View drawer.png 70.9 KB Ohad Levy, 07/19/2017 08:11 AM
Actions #1

Updated by Rahul Bajaj over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Ohad Levy over 6 years ago

Rahul Bajaj wrote:

1) If the notification drawer is open and you forget to close it, it remains open even if you browse to some other page.

That was by design, you could argue against it.

2) Notification drawer has a weird placement, as in its far from its icon(i am not sure why that is happening).

Afair this happens in patternfly too.

3) Notification drawer does not follow the pattern fly standards.

What exactly?

Actions #3

Updated by Rahul Bajaj over 6 years ago

Ohad Levy wrote:

Rahul Bajaj wrote:

1) If the notification drawer is open and you forget to close it, it remains open even if you browse to some other page.

That was by design, you could argue against it.

If you go to : http://www.patternfly.org/pattern-library/communication/notification-drawer/notification-drawer-horizontal-nav.html
and open the notification bar and then refresh, you will notice that the notification bar is hidden.

2) Notification drawer has a weird placement, as in its far from its icon(i am not sure why that is happening).

Afair this happens in patternfly too.

Nope, it doesnt. we have it(right: 0) set in our css. If you make it right:auto then it should work just fine.

Actions #4

Updated by Ohad Levy over 6 years ago

Rahul Bajaj wrote:

Ohad Levy wrote:

Rahul Bajaj wrote:

1) If the notification drawer is open and you forget to close it, it remains open even if you browse to some other page.

That was by design, you could argue against it.

If you go to : http://www.patternfly.org/pattern-library/communication/notification-drawer/notification-drawer-horizontal-nav.html
and open the notification bar and then refresh, you will notice that the notification bar is hidden.

we have some pages that might refresh the page (e.g. dashboard).
I don't have a strong opinion on this feature, I suggest opening a PR and asking Rox for her feedback.

2) Notification drawer has a weird placement, as in its far from its icon(i am not sure why that is happening).

Afair this happens in patternfly too.

Nope, it doesnt. we have it(right: 0) set in our css. If you make it right:auto then it should work just fine.

right:auto does not work as expected for me, if I change it then the notification drawer is partly hidden to the right and i have to scroll (see attachment)

Actions #5

Updated by Rahul Bajaj over 6 years ago

Ohad Levy wrote:

Rahul Bajaj wrote:

Ohad Levy wrote:

Rahul Bajaj wrote:

1) If the notification drawer is open and you forget to close it, it remains open even if you browse to some other page.

That was by design, you could argue against it.

If you go to : http://www.patternfly.org/pattern-library/communication/notification-drawer/notification-drawer-horizontal-nav.html
and open the notification bar and then refresh, you will notice that the notification bar is hidden.

we have some pages that might refresh the page (e.g. dashboard).
I don't have a strong opinion on this feature, I suggest opening a PR and asking Rox for her feedback.

I shall do that :)

2) Notification drawer has a weird placement, as in its far from its icon(i am not sure why that is happening).

Afair this happens in patternfly too.

Nope, it doesnt. we have it(right: 0) set in our css. If you make it right:auto then it should work just fine.

right:auto does not work as expected for me, if I change it then the notification drawer is partly hidden to the right and i have to scroll (see attachment)

Ah! i see, then may be the correct fix to my problem[attachment] would be making the notification bar's position:relative in the '#notifications_container' class

Actions #6

Updated by Rahul Bajaj over 6 years ago

  • Target version changed from 1.17.0-RC1 to 1.15.6
Actions #7

Updated by Rahul Bajaj over 6 years ago

  • Assignee deleted (Rahul Bajaj)
  • Target version deleted (1.15.6)
Actions #8

Updated by Ohad Levy over 6 years ago

  • Status changed from New to Feedback
Actions

Also available in: Atom PDF