Project

General

Profile

Actions
Copy link

Refactor #22994

closed

The namespace for apidoc doesn't seem to be right

Added by Oleh Fedorenko about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Oleh Fedorenko
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_ansible/pull/151
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently the routes in the apidoc defined (listing all ansible roles for example) as

api :GET, '/ansible/ansible_roles'

which produces in the apidoc:
/ansible/api/ansible_roles

But actual route is 
ansible/api/v2/ansible_roles

And this causes some problems when using hammer (hammer uses different route). So, I suggest a small refactor for ansible_roles controller, see PR:

Actions
Copy link
 #1

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_ansible/pull/151 added
Actions
Copy link
 #2

Updated by Oleh Fedorenko about 6 years ago

Just noticed:

which produces in the apidoc:
[...]
But actual route is
[...]

actually refers the same thing. Just to clarify:

before PR it produced

api/ansible/ansible_roles

which isn't correct since ansible plugin has its own namespace, so it looks like:

ansible/api/ansible_roles

Actions
Copy link
 #3

Updated by Daniel Lobato Garcia about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF