Project

General

Profile

Actions

Bug #23433

closed

ISC DHCP new parser my break when parsing lease uids

Added by Anonymous almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
DHCP
Target version:
Fixed in Releases:
Found in Releases:

Related issues 2 (0 open2 closed)

Related to Smart Proxy - Bug #23031: ISC DHCP new parser is still unable to parse DUIDClosedActions
Related to Smart Proxy - Bug #24978: ISC DHCP parser does not support DDNS entriesClosedLukas ZapletalActions
Actions #1

Updated by Anonymous almost 6 years ago

  • Related to Bug #23031: ISC DHCP new parser is still unable to parse DUID added
Actions #2

Updated by Huaqing Z almost 6 years ago

The literal regex is still broken.

        def server_duid
          Rsec::Fail.reset
          keyword = word('server-duid').fail 'keyword_server_duid'
          anything = /[^;,{}\s]+/.r
          literal = /"([^"]|\")*"/.r

fails on

server-duid "\000\001\000\001\"vt\346\000PV\225S\347";

Changing the regex to

          literal = /"([^"]|\\\")*"/.r

Though you could just literally do /".*"/ and rely on greedy regex match to fix the issue and simplify the code.

Actions #3

Updated by The Foreman Bot almost 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Anonymous
  • Pull request https://github.com/theforeman/smart-proxy/pull/583 added
Actions #4

Updated by Anonymous almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Ivan Necas almost 6 years ago

  • translation missing: en.field_release set to 330

I guess this should be pulled into 1.18 release

Actions #6

Updated by Timo Goebel almost 6 years ago

1.17 branch would be even better. Unfortunately, I can't update the release field.

Actions #7

Updated by The Foreman Bot almost 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/588 added
Actions #8

Updated by Lukas Zapletal almost 6 years ago

  • Category set to DHCP
  • translation missing: en.field_release changed from 330 to 360

Requesting backport into 1.17, this is an important one: #23784

Actions #9

Updated by Han Boetes almost 6 years ago

I concur, this is an important patch. For anyone wanting to try the patch on 1.17:
Actions #10

Updated by Ian Freislich over 5 years ago

  • Related to Bug #24978: ISC DHCP parser does not support DDNS entries added
Actions

Also available in: Atom PDF