Refactor #260
Switch family implemetation to use STI
| Status: | Closed | Start: | 05/21/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned to: |  Paul Kelly |
% Done: | 100% |
|
| Category: | Rails | |||
| Target version: | 0.1-6 | |||
| Backlog: | Difficulity: | |||
| Votes: | 0 |
Description
The home grown class inheritance stuff in family is confusing.
Switch to using a set of classes based upon the Operatingsystem
Related issues
| blocks Foreman - Feature #178: Automate populating the TFTP directory | Closed | 03/14/2010 |
Associated revisions
Revision 2c83f7442b4588f0e65531f735b844457ea7d41c
Fixes #260 - Switch to using STI for OS families
History
Updated by Paul Kelly about 3 years ago
- Status changed from New to Feedback
- Branch set to refactor/260-family-with-sti
Updated by Paul Kelly about 3 years ago
By adding a 'type' field to the operatingsystem record and then managing this field manually we can make Rails cast the record to the required family class.
Updated by Ohad Levy about 3 years ago
- Target version set to 0.1-6
Updated by Paul Kelly about 3 years ago
Added OS before_filter to deduce the family, if not set
OS DB entries can now contain a null type
@@families promoted to Operatingsystem::FAMILIES
Included mods suggested by Ohad
Updated by Paul Kelly about 3 years ago
Rebased
Centralized Family name and os membership list into a single hash
Added test in unattended controller that detects if a os has no family
simplified deduce_family
tests pass
Updated by Paul Kelly almost 3 years ago
- Status changed from Feedback to Ready For Testing
- % Done changed from 0 to 100
Applied in changeset 2c83f7442b4588f0e65531f735b844457ea7d41c.
Updated by Ohad Levy almost 3 years ago
- Status changed from Ready For Testing to Closed
