Bug #443

The host index operation fails when not including a :fact_values eager loader

Added by Paul Kelly over 2 years ago. Updated over 2 years ago.

Status:Closed Start:11/09/2010
Priority:Normal Due date:
Assigned to:Paul Kelly % Done:

100%

Category:Rails
Target version:0.1-6
Backlog:No Difficulity:
Votes: 0

Description

In the case that a user with a fact_filter tries to index the hosts, the operation will fail unless there is an eager load of fact_values.
Eager loading fact_values is slow.

Associated revisions

Revision 02acc2ecef35ea600fc1ae6d80d71009f1472df5
Added by Ohad Levy over 2 years ago

Fixes #443 - remove unnecassary fact_values loading

This fix does not explain why you need to include :fact_values to
avoid an SQL error. However this includes the fact_values when you do
really need them and does not when you don't

Refactored show_hosts and index
Added a test for json + fact filter
Updated default access permsssions to add support for show_hosts functions

History

Updated by Ohad Levy over 2 years ago

  • Target version set to 0.1-6

Updated by Paul Kelly over 2 years ago

  • Status changed from New to Ready For Testing
  • Branch set to bug/443-fact_values-loading

rebased and tested

Updated by Paul Kelly over 2 years ago

Refactored show_hosts and index
Added test for json for a user with a fact filter.
Added some missing default_access permissions
Rebased and tested

Updated by Ohad Levy over 2 years ago

  • % Done changed from 0 to 100

Updated by Ohad Levy over 2 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF