Project

General

Profile

Actions

Bug #623

closed

Multiple build commit was incomplete

Added by Paul Kelly about 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
TFTP
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The commit was missing the app/views/hosts/multiple_build.html.erb file

plus

There was also a missing call to the forward_request_url method


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #350: Provide the ability to set the build option when editing multiple hostsClosedPaul Kelly07/12/2010Actions
Actions #1

Updated by Paul Kelly about 13 years ago

  • Status changed from New to Ready For Testing
  • Branch set to bug/623-incomplete-multiple-builds

Added the missing multiple_build.html.erb file
Fixed the forward_request_url issue

  • Could you review the queue_tftp_update method and confirm that the line reading "end unless" is correct. **
Actions #2

Updated by Paul Kelly about 13 years ago

Added tests per request

What did you think about the:-

Could you review the queue_tftp_update method and confirm that the line reading "end unless" is correct.
Actions #3

Updated by Ohad Levy about 13 years ago

Paul Kelly wrote:

Added tests per request

What did you think about the:-

Could you review the queue_tftp_update method and confirm that the line reading "end unless" is correct.

hmm thats looks like a mistake - nice catch

Actions #4

Updated by Ohad Levy about 13 years ago

  • Target version set to 0.2
Actions #5

Updated by Ohad Levy about 13 years ago

can you please rebase and post it again the to list?

Actions #6

Updated by Paul Kelly about 13 years ago

rebased, tested and mailed

Actions #7

Updated by Paul Kelly about 13 years ago

  • % Done changed from 0 to 100
Actions #8

Updated by Ohad Levy about 13 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF