Project

General

Profile

Actions

Bug #8675

closed

rubocop does not ignore engines/bastion_katello/node_modules/ files

Added by Justin Sherrill over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
trivial
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

es.rb:4:1: C: Extra empty line detected at body beginning.
engines/bastion_katello/node_modules/bastion/config/routes.rb:12:42: W: Unused block argument - name. If it's necessary, use _ or _name as an argument name to indicate that it won't be used.
pages = Bastion.plugins.collect { |name, plugin| plugin[:pages] }
^^^
engines/bastion_katello/node_modules/bastion/config/routes.rb:15:1: C: Extra empty line detected at body end.
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:4:1: C: Favor if over unless for negative conditions.
require lib_foreman unless !Dir.exist?(lib_foreman)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:12:1: C: Extra empty line detected at body beginning.
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:13:3: C: Replace class var @plugins with a class instance var.
@plugins = {};
^^^^^^^
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:13:17: C: Do not use semicolons to terminate expressions.
@@plugins = {};
^
engines/bastion_katello/node_modules/bastion/lib/bastion.rb:22:1: C: Extra empty line detected at body end.
engines/bastion_katello/node_modules/bastion/lib/bastion/engine.rb:5:1: C: Extra empty line detected at body beginning.
engines/bastion_katello/node_modules/bastion/lib/bastion/engine.rb:40:1: C: Extra empty line detected at body end.

Actions #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/4869 added
  • Pull request deleted ()
Actions #2

Updated by Justin Sherrill over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Eric Helms about 9 years ago

  • translation missing: en.field_release set to 23
Actions

Also available in: Atom PDF