Project

General

Profile

Actions
Copy link

Bug #9796

closed

Badly marked translations for loading subscriptions loading screens

Added by Walden Raines about 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Walden Raines
Category:
Web UI
Target version:
Katello 2.3.0
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/5116
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The translations were marked like so:

        <td colspan="9" translate>
           <div class="loading-mask fa-3x" ng-show="working">
             <i class="fa fa-spinner fa-spin"></i>
             {{ "Loading..." | translate }}
           </div>
       </td>

Which results in the entire inside of the <td> being marked for translation. We should not be marking HTML for translation

Actions
Copy link
 #1

Updated by The Foreman Bot about 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5116 added
  • Pull request deleted ()
Actions
Copy link
 #2

Updated by Walden Raines about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Eric Helms almost 9 years ago

  • translation missing: en.field_release set to 31
Actions
Copy link

Also available in: Atom PDF