Project

General

Profile

Actions

Bug #9981

closed

Smart variable doesn't show error on new variable

Added by Ori Rabin almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Steps to reproduce:
1. create a new smart variable with parameter type integer and a matcher with the value 'abc'
2. try to save the puppetclass

Expected result: tab becomes red, next to value an error message "is invalid integer"

Actual result: the variable disappears and the puppetclass can't be saved

Workaround for now: save the puppetclass when the variable is empty (only parameter, type and default value) and then edit.
When the variable is updated the validations are shown correctly.


Related issues 2 (1 open1 closed)

Related to Foreman - Tracker #4470: Usability of parameters and overridesNew

Actions
Related to Foreman - Bug #8416: Puppetclasses edit n+1 queryClosedDaniel Lobato Garcia11/16/2014Actions
Actions #1

Updated by Ori Rabin almost 9 years ago

  • Related to Tracker #4470: Usability of parameters and overrides added
Actions #2

Updated by Walden Raines over 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Walden Raines
Actions #3

Updated by Walden Raines over 8 years ago

There are, in fact, two issues here.

1. If you don't enter a key then it saves the puppet class but does not attempt to save the new smart variable at all and spits you out on the puppetclasses list page
2. If you enter a key and also enter an invalid default value (a string for an int, for example) then the form marks itself as invalid but does not specify what the actual issue is

Actions #4

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2693 added
  • Pull request deleted ()
Actions #5

Updated by Ori Rabin over 8 years ago

  • Assignee changed from Walden Raines to Tom Caspy
Actions #6

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #8416: Puppetclasses edit n+1 query added
Actions #7

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 71
Actions #8

Updated by Tom Caspy over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF