Project

General

Profile

Bug #12765

Inconsistent rule ordering in the UI

Added by Lukas Zapletal over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Discovery plugin
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_discovery/pull/255
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We order rules by priority (ascending):

https://github.com/theforeman/foreman_discovery/blob/develop/app/controllers/concerns/foreman/controller/discovered_extensions.rb#L5-L33

but in the UI page we list them in descending order. This can be confusing. We should correct our docs and be more explicit too.

Related issues

Related to Discovery - Bug #13217: Discovery Rules order by name, not priorityClosed2016-01-14

Associated revisions

Revision 730006ca (diff)
Added by Lukas Zapletal about 7 years ago

Fixes #12765 - rule ordering in UI by priority and creation time

History

#1 Updated by Lukas Zapletal about 7 years ago

  • Related to Bug #13217: Discovery Rules order by name, not priority added

#2 Updated by Lukas Zapletal about 7 years ago

The description is incorrect. We DO sort them in ascending order in the UI, that's correct behavior.

But we should also sort by created_at for those with same priority. I currently don't know how to implement this with Scoped Search as it only accepts one sort column: resource_base.search_for(params[:search], :order => (params[:order] || 'priority ASC'))

#3 Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman_discovery/pull/255 added

#4 Updated by Anonymous about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF