Project

General

Profile

Bug #13830

Remove '--new-name' option from sc-param to not to update the param name.

Added by Jitendra Yejare about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Foreman commands (obsolete)
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1310568
Description of problem:
Currently '--new-name' option is shown to update the smart class parameter name from CLI. But actually smart class parameter name should not be updated by any means. This option is applicable in case of 'smart variable' only.

Version-Release number of selected component (if applicable):
foreman-1.11.0-0.develop.201602171602gitd5b5059.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. Attempt to update the smart class parameter name using CLI hammer commnad:
  1. hammer sc-param update --new-name <new_anme> --id <sc-params id>

Actual results:
Success !

Example Output:
[root@qeblade36 ~]# hammer sc-param update --help
Ignoring ruby-libvirt-0.5.2 because its extensions are not built. Try: gem pristine ruby-libvirt --version 0.5.2
Usage:
hammer sc-param update [OPTIONS]

Options:
--avoid-duplicates AVOID_DUPLICATES Remove duplicate values (only array type)
One of true/false, yes/no, 1/0.
--default-value DEFAULT_VALUE Value to use when there is no match
--description DESCRIPTION Description of smart class
--hidden-value HIDDEN_VALUE When enabled the parameter is hidden in the UI
One of true/false, yes/no, 1/0.
--id ID
--merge-default MERGE_DEFAULT Include default value when merging all matching values
One of true/false, yes/no, 1/0.
--merge-overrides MERGE_OVERRIDES Merge all matching values (only array/hash type)
One of true/false, yes/no, 1/0.
--name NAME Smart class parameter name
--new-name NEW_NAME
--override OVERRIDE Override this parameter.
One of true/false, yes/no, 1/0.
--override-value-order OVERRIDE_VALUE_ORDER The order in which values are resolved
--parameter-type PARAMETER_TYPE Type of the parameter.
Possible value(s): 'string', 'boolean', 'integer', 'real', 'array', 'hash', 'yaml', 'json'
--path PATH The order in which values are resolved
--puppet-class PUPPET_CLASS_NAME Puppet class name
--puppet-class-id PUPPET_CLASS_ID ID of Puppet class
--required REQUIRED This parameter is required.
One of true/false, yes/no, 1/0.
--use-puppet-default USE_PUPPET_DEFAULT Do not send this parameter via the ENC. Puppet will use the value defined
in the Puppet manifest for this parameter
One of true/false, yes/no, 1/0.
--validator-rule VALIDATOR_RULE Used to enforce certain values for the parameter values
--validator-type VALIDATOR_TYPE Type of the validator.
Possible value(s): 'regexp', 'list', ''
-h, --help print help

Expected results:
The '--new-name' option should not be available for sc-param.

Associated revisions

Revision 90ec6454 (diff)
Added by Tomas Strachota about 4 years ago

Fixes #13830 - names of sc-params are immutable

Revision f995efc0
Added by Martin Bacovsky about 4 years ago

Merge pull request #216 from tstrachota/sc_param_name_13830

Fixes #13830 - names of sc-params are immutable

History

#1 Updated by Dominic Cleal about 4 years ago

  • Project changed from Foreman to Hammer CLI
  • Category set to Foreman commands (obsolete)

#2 Updated by Tomáš Strachota about 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomáš Strachota

#3 Updated by The Foreman Bot about 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/216 added

#4 Updated by Anonymous about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF