FactValue association to Host should be against Host::Base
As described on http://projects.theforeman.org/issues/16081 - the fact_values helper is expecting that "fact_value.host" to return a meaningful value all the time.
However for certain hosts (DiscoveredHost now, but it could be others in the future) /fact_values shows a 500 because "fact_value.host" doesn't exist.
I think it'd be reasonable to expect fact_value.host to exist for Hosts in core, but we should show N/A if that cannot be found. This way the page will be more resilient to manual db manipulation, data corruption, or plain bugs like http://projects.theforeman.org/issues/16081 .
#7 Updated by Dominic Cleal over 1 year ago
- Subject changed from Facts helper should show N/A if host couldn't be found to FactValue association to Host should be against Host::Base
- Status changed from Rejected to Ready For Testing
- Assignee changed from Daniel Lobato Garcia to Tomer Brisker
- Target version deleted (
- Pull request https://github.com/theforeman/foreman/pull/4441 added
A pull request has been merged referencing this previously closed/rejected bug report. Please check when merging PRs that the report is valid.