Project

General

Profile

Actions
Copy link

Bug #26456

closed

maintenance-mode is-enabled exit codes do not match shell habits

Added by Martin Bacovsky about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Kavita Gaikwad
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_maintain/pull/252
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

In shell it is expected the positive response is indicated by zero exit code. It allows us to do 

foreman-maintain maintenance-mode is-enabled || foreman-maintain maintenance-mode start

which is common pattern in shell scripting.

Currently the is-enabled returns the opposite codes which may be confusing for some users.

Actions
Copy link
 #1

Updated by Kavita Gaikwad about 5 years ago

  • Assignee set to Kavita Gaikwad
Actions
Copy link
 #2

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_maintain/pull/252 added
Actions
Copy link
 #3

Updated by Kavita Gaikwad about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF