Project

General

Profile

Refactor #33259

Don't store @context in field params

Added by Oleh Fedorenko 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Oleh Fedorenko
Category:
Hammer core
Target version:
-
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/hammer-cli/pull/353
Team Backlog:
Fixed in Releases:
hammer-cli-3.1.0
Found in Releases:
In Kanboard:

Description

Few places [1], [2] in hammer core inject @context variable into field parameters. Although only :show_ids flag is used in formatters afterwards. There is no actual value to have such global variable accessible in formatters. This also leads to

Error: singleton can't be dumped

after https://github.com/theforeman/hammer-cli/commit/c8430df12d28856abcdb9ca076040ca9cbe72c8c patch.

[1] - https://github.com/theforeman/hammer-cli/blob/c8430df12d28856abcdb9ca076040ca9cbe72c8c/lib/hammer_cli/output/adapter/base.rb#L79
[2] - https://github.com/theforeman/hammer-cli/blob/c8430df12d28856abcdb9ca076040ca9cbe72c8c/lib/hammer_cli/output/adapter/tree_structure.rb#L58

Associated revisions

Revision 20855652 (diff)
Added by Oleh Fedorenko 5 months ago

Fixes #33259 - Don't store @context in field params

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/353 added

#2 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases hammer-cli-3.1.0 added

#3 Updated by Oleh Fedorenko 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF