Refactor #33259
Don't store @context in field params
Difficulty:
trivial
Triaged:
Yes
Pull request:
Description
Few places [1], [2] in hammer core inject @context variable into field parameters. Although only :show_ids flag is used in formatters afterwards. There is no actual value to have such global variable accessible in formatters. This also leads to
Error: singleton can't be dumped
after https://github.com/theforeman/hammer-cli/commit/c8430df12d28856abcdb9ca076040ca9cbe72c8c patch.
[1] - https://github.com/theforeman/hammer-cli/blob/c8430df12d28856abcdb9ca076040ca9cbe72c8c/lib/hammer_cli/output/adapter/base.rb#L79
[2] - https://github.com/theforeman/hammer-cli/blob/c8430df12d28856abcdb9ca076040ca9cbe72c8c/lib/hammer_cli/output/adapter/tree_structure.rb#L58
Associated revisions
History
#1
Updated by The Foreman Bot about 1 year ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli/pull/353 added
#2
Updated by The Foreman Bot about 1 year ago
- Fixed in Releases hammer-cli-3.1.0 added
#3
Updated by Oleh Fedorenko about 1 year ago
- Status changed from Ready For Testing to Closed
Applied in changeset 20855652babee32129e1f502cb26cc3268bff4a5.
Fixes #33259 - Don't store @context in field params