Project

General

Profile

Bug #8855

Oj gem hides rabl errors in development

Added by Justin Sherrill almost 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When writing rabl it is very easy to return AR objects instead of simple data structures in rabl:

http://projects.theforeman.org/issues/8774
http://projects.theforeman.org/issues/6215

in development this works fine since the OJ gem is loaded. In production this will fail and is difficult to debug since it does not occur in development. We should try to remove the Oj gem for better parity between dev and prod

Quoting dom:

                  │09:02:02         Dominic | should be possible to remove it, I think we added it for some new test in the auth system                     

Associated revisions

Revision 5a09c3ac (diff)
Added by Dominic Cleal almost 7 years ago

fixes #8855 - remove unused oj gem

History

#1 Updated by Dominic Cleal almost 7 years ago

  • Assignee set to Dominic Cleal

#2 Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2073 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF