Project

General

Profile

Actions
Copy link

Bug #8855

closed

Oj gem hides rabl errors in development

Added by Justin Sherrill almost 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Tests
Target version:
1.8.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2073
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

When writing rabl it is very easy to return AR objects instead of simple data structures in rabl:

http://projects.theforeman.org/issues/8774
http://projects.theforeman.org/issues/6215

in development this works fine since the OJ gem is loaded. In production this will fail and is difficult to debug since it does not occur in development. We should try to remove the Oj gem for better parity between dev and prod

Quoting dom:

                  │09:02:02         Dominic | should be possible to remove it, I think we added it for some new test in the auth system
Actions
Copy link
 #1

Updated by Dominic Cleal over 9 years ago

  • Assignee set to Dominic Cleal
Actions
Copy link
 #2

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2073 added
  • Pull request deleted ()
Actions
Copy link
 #3

Updated by Dominic Cleal over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Dominic Cleal over 9 years ago

  • Translation missing: en.field_release set to 28
Actions
Copy link

Also available in: Atom PDF