Project

General

Profile

Actions

Bug #8855

closed

Oj gem hides rabl errors in development

Added by Justin Sherrill about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When writing rabl it is very easy to return AR objects instead of simple data structures in rabl:

http://projects.theforeman.org/issues/8774
http://projects.theforeman.org/issues/6215

in development this works fine since the OJ gem is loaded. In production this will fail and is difficult to debug since it does not occur in development. We should try to remove the Oj gem for better parity between dev and prod

Quoting dom:

                  │09:02:02         Dominic | should be possible to remove it, I think we added it for some new test in the auth system                     
Actions #1

Updated by Dominic Cleal about 9 years ago

  • Assignee set to Dominic Cleal
Actions #2

Updated by The Foreman Bot about 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2073 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 28
Actions

Also available in: Atom PDF