Project

General

Profile

Bug #9500

Wrong domain assigned when they have intersection in the middle of name

Added by Marek Hulán almost 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Network
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Having a hostname "something.example.org.com" and domain "example.org" would match in Nic::Interface#normalize_name resulting in assigning wrong domain.

Associated revisions

Revision ede6d4ea (diff)
Added by Marek Hulán almost 7 years ago

Fixes #9500 - matching uses the whole domain name

Revision 6ee8b1c2 (diff)
Added by Daniel Lobato Garcia almost 7 years ago

Refs #9500 - revert normalize_name tests

Current test "#normalize_hostname sets a domain based on name that contains its name if it's nil and such domain exists" is not testing anything because Domain.all does not return any domains to match (as .create was substituted on merge by .build).

Revision f9ba7275 (diff)
Added by Marek Hulán almost 7 years ago

Fixes #9500 - matching uses the whole domain name

(cherry picked from commit ede6d4ea8b266e3a90fc6c639929be2b55be225c)

Revision adb9247c (diff)
Added by Daniel Lobato Garcia almost 7 years ago

Refs #9500 - revert normalize_name tests

Current test "#normalize_hostname sets a domain based on name that contains its name if it's nil and such domain exists" is not testing anything because Domain.all does not return any domains to match (as .create was substituted on merge by .build).
(cherry picked from commit 6ee8b1c279468601dc2399448f70244f24f58d37)

History

#1 Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2189 added
  • Pull request deleted ()

#2 Updated by Marek Hulán almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal almost 7 years ago

  • Legacy Backlogs Release (now unused) set to 28

Also available in: Atom PDF