Docker: Issueshttps://projects.theforeman.org/https://projects.theforeman.org/favicon.ico?16970236342019-11-26T15:09:07ZForeman
Redmine Refactor #28364 (Closed): Drop docker runtime related commands from hammerhttps://projects.theforeman.org/issues/283642019-11-26T15:09:07ZOndřej Pražák
<p>hammer_cli_foreman_docker should contain only commands for docker content</p> Refactor #23528 (New): containers_controller deprecation on fixnumhttps://projects.theforeman.org/issues/235282018-05-07T10:01:46ZOhad Levyohadlevy@gmail.com
<p>saw in logs</p>
<pre>
foreman_docker-4.1.0/app/controllers/api/v2/containers_controller.rb:107: warning: constant ::Fixnum is deprecated
</pre> Refactor #22046 (Closed): use rubocop 0.52https://projects.theforeman.org/issues/220462017-12-20T20:45:52ZAnonymousRefactor #22045 (Closed): make Rails 5.1 compatiblehttps://projects.theforeman.org/issues/220452017-12-20T20:31:26ZAnonymousRefactor #21921 (Closed): Upgrade rubocop to 0.51 https://projects.theforeman.org/issues/219212017-12-10T16:29:04ZAnonymousRefactor #21814 (Closed): Add Rails 5 style migrationshttps://projects.theforeman.org/issues/218142017-11-30T10:02:39ZOndřej Pražák
<p>Migrations need a change in order to move to Rails 5.1</p> Refactor #21732 (Closed): Replace :before_filter with :before_actionhttps://projects.theforeman.org/issues/217322017-11-22T10:32:42ZOndřej Pražák
<p>We should replace :before_filter as we are getting closer to Rails 5.1</p> Refactor #21042 (New): Ensure dates are printed consistently with corehttps://projects.theforeman.org/issues/210422017-09-20T12:54:26ZMarek Hulánmhulan@redhat.com
<p>Foreman 1.16 introduced two helpers that should be used whenever date/time information is printed.</p>
<pre><code class="ruby syntaxhl" data-language="ruby"><span class="n">date_time_absolute</span><span class="p">(</span><span class="n">time</span><span class="p">,</span> <span class="nb">format</span> <span class="o">=</span> <span class="ss">:short</span><span class="p">)</span>
<span class="n">date_time_relative</span><span class="p">(</span><span class="n">time</span><span class="p">)</span>
</code></pre>
<p>If it's applicable, the Foreman dependency of a plugin should be bumped to 1.16</p> Refactor #19964 (Closed): Rewrite models to use ApplicationRecordhttps://projects.theforeman.org/issues/199642017-06-08T07:16:09ZSebastian Gräßl
<p>See <a class="external" href="https://github.com/theforeman/foreman/pull/3729">https://github.com/theforeman/foreman/pull/3729</a></p> Refactor #19694 (Closed): Align Rubocop with foreman core settingshttps://projects.theforeman.org/issues/196942017-05-29T02:59:10ZSebastian GräßlRefactor #14581 (Closed): Fix migrations for Rails 4.2https://projects.theforeman.org/issues/145812016-04-11T14:38:41ZDavid Davisdaviddavis@redhat.com
<pre>
PG::Error: ERROR: constraint "containers_docker_image_id_fk" of relation "containers" does not exist
: ALTER TABLE "containers" DROP CONSTRAINT "containers_docker_image_id_fk"/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/connection_adapters/postgresql/database_statements
.rb:155:in `exec'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/connection_adapters/postgresql/database_statements.rb:155:in `block in execute'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract_adapter.rb:472:in `block in log'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activesupport-4.2.6/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract_adapter.rb:466:in `log'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/connection_adapters/postgresql/database_statements.rb:154:in `execute'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/connection_adapters/abstract/schema_statements.rb:815:in `remove_foreign_key'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/migration.rb:665:in `block in method_missing'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/migration.rb:634:in `block in say_with_time'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/migration.rb:634:in `say_with_time'
/home/vagrant/.rvm/gems/ruby-2.2.4@foreman/gems/activerecord-4.2.6/lib/active_record/migration.rb:654:in `method_missing'
/home/vagrant/foreman-docker/db/migrate/20141209182008_remove_docker_tables.rb:23:in `up'
</pre> Refactor #13043 (Closed): Remove Parameter inheritance from EnvironmentVariables, ExposedPort, Dnshttps://projects.theforeman.org/issues/130432016-01-07T07:52:48ZOri Rabinorabin@redhat.com
<p>Parameters will be changed as part of: <a class="external" href="http://projects.theforeman.org/issues/12950">http://projects.theforeman.org/issues/12950</a><br />EnvironmentVariables need a simple key-value structure and shouldn't be changed so they should stop inheriting from Parameters.</p> Refactor #10812 (Closed): Remove require 'fog'https://projects.theforeman.org/issues/108122015-06-15T05:09:31ZDominic Clealdominic@cleal.org
<p>In <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Refactor: Remove require 'fog' and only load specific providers (Closed)" href="https://projects.theforeman.org/issues/8516">#8516</a> (Foreman 1.9.0) we removed the <code>require 'fog'</code> from core and now only load parts of Fog that we need, e.g. 'fog/libvirt'.</p>
<p>foreman_docker has a require 'fog' call here, which can be removed to give a performance boost: <a class="external" href="https://github.com/theforeman/foreman-docker/blob/master/lib/foreman_docker/engine.rb#L3">https://github.com/theforeman/foreman-docker/blob/master/lib/foreman_docker/engine.rb#L3</a></p> Refactor #8792 (Resolved): Delete wizard states on container creationhttps://projects.theforeman.org/issues/87922014-12-26T04:54:56ZDaniel Lobato Garciaelobatocs@gmail.com
<p>After a container is created, all wizard states generated to create it can be flushed from the database. This way we can keep the database clean of wizard state objects without a cron job to routinely delete them</p> Refactor #8718 (Closed): containers index page uses both traditional table and inline table jshttps://projects.theforeman.org/issues/87182014-12-15T16:39:53ZOhad Levyohadlevy@gmail.com
<p>this was not visible due to a missing thead and a closing div on the index page.</p>