Project

General

Profile

Actions

Bug #10264

closed

DHCP smart proxy implementation does not honor configured omapi port for ISC dhcpd

Added by Florian Maier almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
DHCP
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Related to: https://groups.google.com/forum/#!topic/foreman-dev/Wwa7kDQG_CM

The current ISC DHCP smart proxy implementation (and docs [1]+[2]) references the omapi-port (default 7911), but does not actually read this setting from dhcpd.conf.
A call to omshell from smart-proxy/modules/dhcp/providers/server/isc.rb is therefore falling back to the default port 7911.

I prepared a simple fix (needs further testing) and do think it might also be helpful to add this default to the configuration example. Pull request currently in the works.

[1] http://projects.theforeman.org/projects/smart-proxy/wiki/ISC_DHCP
[2] http://projects.theforeman.org/projects/smart-proxy/wiki/Sample_dhcpdconf

Actions #1

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/280 added
  • Pull request deleted ()
Actions #2

Updated by Dominic Cleal almost 9 years ago

  • Category set to DHCP
  • Assignee set to Florian Maier
Actions #3

Updated by Florian Maier almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release set to 35
Actions

Also available in: Atom PDF