Project

General

Profile

Actions

Bug #10390

closed

Kafo do not run hooks in expected order on ruby 1.8

Added by Martin Bacovsky about 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Normal
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1218792
Description of problem:
When there is more installer hooks in one category (e.g. 'pre-validation') Kafo is supposed to execute them in alphabetical order. That does not happen on Ruby 1.8 and the order is unpredictable.

Version-Release number of selected component (if applicable):

How reproducible:
Sometimes

Steps to Reproduce:
1. add hooks to one hook category that are just logging something
2. run installer multiple times on system with ruby 1.8
3. the order in log differs

Actual results:

Expected results:
The hooks are executed in alphabetical order

Additional info:
AFAIK we do not have hooks that depend on the order in Sat 6, I hit this issue while adding hooks for RHCI

Actions #1

Updated by Martin Bacovsky about 10 years ago

  • Status changed from New to Assigned

Hooks are stored in a hash that has unpredictable ordering in Ruby 1.8

Actions #2

Updated by The Foreman Bot about 10 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/kafo/pull/110 added
  • Pull request deleted ()
Actions #3

Updated by Anonymous about 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF