Project

General

Profile

Actions

Bug #10589

closed

N+1 Query when changing hostgroup from the "All Hosts" page

Added by Ryan Sabatini almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Performance
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

I believe there is a N+1 query when modifying a single host or multiple hosts from the "All Hosts" page of the Foreman. Changing a hostgroup from this page is taking ~5-8 minutes to complete depending on the number of hosts being modified.

Found by loading foreman-rake console
hg = Hostgroup.find_by_id(1)
h = Host.find_by_name("name of host")
h.hostgroup=hg
h.save(:validate => false)

I've attached the specific query that I believe has the N+1. It is executed several times in this block of code which I think is the reason the host group change takes such a long time to complete.


Files

Foreman N+1.rtf Foreman N+1.rtf 259 KB Ryan Sabatini, 05/22/2015 10:13 AM

Related issues 1 (1 open0 closed)

Related to Foreman - Tracker #11657: Performance refactoring for HostsControllerNew09/02/2015

Actions
Actions #1

Updated by Dominic Cleal almost 9 years ago

  • Category set to Performance
Actions #2

Updated by Bryan Kearney over 8 years ago

  • Bugzilla link set to 1257268
Actions #3

Updated by Ohad Levy over 8 years ago

  • Assignee set to Tom Caspy
Actions #4

Updated by Tom Caspy over 8 years ago

  • Related to Tracker #11657: Performance refactoring for HostsController added
Actions #5

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2684 added
  • Pull request deleted ()
Actions #6

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 72
Actions #7

Updated by Tom Caspy over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #8

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release changed from 72 to 88
Actions

Also available in: Atom PDF