Project

General

Profile

Actions

Bug #10867

closed

Openstack boot from volume always enabled, even if unchecked

Added by Andy Taylor over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Compute resources - OpenStack
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

We've just upgraded our Foreman installation to 1.8.2 and found that our Openstack provisioning stopped working. We've narrowed the issue down to the new Openstack boot from volume code (see http://projects.theforeman.org/issues/4521).

It seems that even if the "Boot from volume" button is unchecked, Foreman still fires the boot_from_volume function in /usr/share/foreman/app/models/compute_resources/foreman/model/openstack.rb. In our infrastructure this broke our provisioning as we don't use Ceph/block device volumes on Openstack.

On line 76 of openstack.rb:

    def create_vm(args = {})
      boot_from_volume(args) if args[:boot_from_volume]
....

When I create a new Openstack VM, boot_from_volume always gets called, even though I can see '"boot_from_volume"=>"false"' in the Foreman logs for the new host.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #4521: Openstack boot from volumeClosedDaniel Lobato Garcia03/03/2014Actions
Actions #1

Updated by Andy Taylor over 8 years ago

Correction, I didn't mean Ceph, I meant Cinder :)

Actions #2

Updated by Marek Hulán over 8 years ago

  • translation missing: en.field_release set to 62
Actions #3

Updated by Marek Hulán over 8 years ago

  • Related to Bug #4521: Openstack boot from volume added
Actions #4

Updated by Daniel Lobato Garcia over 8 years ago

Looks like ` args[:boot_from_volume] ` is going to return true (boolean) for either "true" or "false" strings.

Actions #5

Updated by Dominic Cleal over 8 years ago

Don't forget that we have Foreman::Cast.to_bool now in develop.

Actions #6

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2498 added
  • Pull request deleted ()
Actions #7

Updated by Dominic Cleal over 8 years ago

  • Assignee set to Daniel Lobato Garcia
Actions #8

Updated by Daniel Lobato Garcia over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF