Bug #1129

Summary Puppet Report - require_ssl

Added by Craig White about 3 years ago. Updated over 2 years ago.

Status:ClosedStart date:08/23/2011
Priority:NormalDue date:
Assigned To:Craig White% Done:

100%

Category:-
Target version:1.0
Difficulty: Bugzilla link:
Found in release: Pull request:
Story points-
Velocity based estimate-

Description

Embedded links for hosts in Summary Puppet Report were all http and not https - even if Foreman::Settings::require_ssl true

Patch below works for me...

/var/www/foreman/app/views/host_mailer# diff -u _link_to_host.text.html.erb _link_to_host.text.html.erb-new


--- _link_to_host.text.html.erb    2011-08-23 08:55:51.603479377 -0700
+++ _link_to_host.text.html.erb-new    2011-08-23 08:55:39.993358933 -0700
@@ -1,5 +1,5 @@
 <td style="border: 1px solid #FF9933;
   border-collapse: collapse;
   padding: 4px;
-  background-color: #FFFFFF;"><%= link_to host, host_path(:id => host, :host => @url, :only_path => false) %>
+  background-color: #FFFFFF;"><%= link_to host, host_path(:id => host, :host => @url, :only_path => false, :protocol => SETTINGS[:require_ssl] == true ? "https://" : "http://") %>
 </td>

Associated revisions

Revision 7e46bb61
Added by Ohad Levy over 2 years ago

fixes #1129 Summary Puppet Report - require_ssl, thanks to

History

#1 Updated by Ohad Levy over 2 years ago

  • Assigned To set to Craig White
  • Target version set to 1.0

would you mind sending it as a git patch? this way you would get your credit :)

#2 Updated by Craig White over 2 years ago

I know next to nothing about making a git patch but don't actually care about credit anyway. If you want to clue me in on how to make a git patch file, I'd be happy to do it.

#3 Updated by Jim Bailey over 2 years ago

#4 Updated by Ohad Levy over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF