Project

General

Profile

Actions

Refactor #11449

closed

Don't use therubyracer anymore

Added by Anonymous over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Packaging
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

therubyracer has a longstanding history of problems on non-Linux and non-x86 platforms. It is used via the execjs gem, while execjs itself does support multiple engines and will select itself the one that's best from the available ones. GitLab went through all this and uses node.js now, which means the node.js package must be installed for all execjs related tasks.


Related issues 2 (0 open2 closed)

Related to Foreman - Refactor #16198: Remove therubyracer supportClosedDominic Cleal08/19/2016Actions
Blocks Packaging - Feature #14809: Build RPMs for Fedora 24ClosedDominic Cleal04/26/2016Actions
Actions #1

Updated by Dominic Cleal over 8 years ago

I'd probably like to support both (via bundler groups?) as using therubyracer is easiest for our RPM packaging, since it's already provided by the ruby193 SCL. Alternatively, there's a node010 SCL which may do.

Actions #2

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2648 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 63

I guess you're making a further change to the Debian packages for this? If you could update contribute.md as well on the website it'd be useful, thanks.

Actions #4

Updated by Dominic Cleal over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

https://github.com/theforeman/foreman-packaging/pull/799 is the corresponding change to Debian Jessie and Ubuntu Trusty packages. Everything else remains on therubyracer for now.

Actions #5

Updated by Dominic Cleal almost 8 years ago

Actions #6

Updated by Dominic Cleal over 7 years ago

Actions

Also available in: Atom PDF