Project

General

Profile

Actions

Bug #11921

closed

Features in controller authentication are not loaded correctly if you modify them from plugins

Added by Marek Hulán over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugin integration
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

We use add_smart_proxy_filters helper to configure authentication for requests coming from proxy (usually facts/reports). We pass features of proxies that should be considered as authenticated but since it's on class definition level, it evaluates during load time. If we register new importers that adds new potential feature, they are not re-evaluated. We should use pass Procs and evaluate them during runtime if we need dynamic list.


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #8484: Make SmartProxyAuth concern more useful to pluginsClosedStephen Benjamin11/24/2014Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2752 added
  • Pull request deleted ()
Actions #2

Updated by Marek Hulán over 8 years ago

For reproducers: it happens in development env if something loads v2 hosts controller (e.g. foreman-tasks) because it includes some concern. Then when another plugin registers new fact importer (foreman_chef, or I suppose foreman_salt as well) you won't see it in #require_smart_proxy_or_login among features hence authentication fails.

Actions #3

Updated by Marek Hulán over 8 years ago

  • Related to Feature #8484: Make SmartProxyAuth concern more useful to plugins added
Actions #4

Updated by Marek Hulán over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 104
Actions

Also available in: Atom PDF