Bug #11990: app/services/fact_parser.rb does not return all the virtual interfaces - Foreman

Actions

Copy link

Bug #11990

closed

app/services/fact_parser.rb does not return all the virtual interfaces

Added by Julien Pivotto about 9 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Facts

Target version:

1.10.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2765

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

This looks like a bug:

While taking a look into the foreman code, I saw that snippet in app/services/fact_parser.rb

  def find_physical_interface(interfaces)
    interfaces.detect { |int, _| int.to_s !~ FactParser::VIRTUAL_NAMES }
  end

  def find_virtual_interface(interfaces)
    interfaces.detect { |int, _| int.to_s =~ /#{FactParser::BONDS}/ }
  end

I think this should be

  def find_physical_interface(interfaces)
    interfaces.detect { |int, _| int.to_s !~ FactParser::VIRTUAL_NAMES }
  end

  def find_virtual_interface(interfaces)
    interfaces.detect { |int, _| int.to_s =~ FactParser::VIRTUAL_NAMES }
  end