Table or column widths
|Assigned To:||Tomer Brisker|
|Target version:||Team Daniel - iteration 3|
|Found in release:||Pull request:||https://github.com/theforeman/foreman/pull/3884|
|Velocity based estimate||-|
Spoke briefly with tbrisker in #theforeman, he said to create this.
I am looking at wanting to edit the size of the table or columns in foreman.
Issue 1. is related to the extra column plugin - https://github.com/GregSutcliffe/foreman_column_view - It doesnt truncate long facts, and ends up stretching the width of the column, which then stretches the width of the entire table and makes other columns look strange. Unfortunately I lost my example, but it would be easy to reproduce by setting the fact in the plugin to something like path (or anything that is lengthy)
Issue 2. when creating a longer environment name, it truncates it too much. I know, I know, these two issues kind of conflict. But the issue is, the main env we use is production. Then there is production_something, production_something_else, production_something_etc. Every one of these environments show up as production_ so it is nearly impossible, without pausing the mouse on the environment of each server, to tell what environment its actually in.
A way to change column or table width would be helpful. Mainly table width, because there is so much unused whitespace on the left and right ;)
#2 Updated by Jeff Sparrow almost 2 years ago
Dominic Cleal wrote:
Looks like it huh? Not sure about Issue 1 though, as I havent looked in to how the plugin actually inputs the fact info. If the table features are added to foreman, a question would be if those would also control that plugins information. Right now its only the data from that plugin that doesnt get truncated, all other columns do, just fyi.
#4 Updated by Tomer Brisker almost 2 years ago
Thank you for you input.
I'll start with point no. 2 - #8800 has just been merged into nightly, which should improve the situation a bit by only clipping cells that need clipping. Once Patternfly (#4629) gets merged this will improve even more as the base content width will be increased to 1400px.
As to issue no. 1 - since #8800 has been merged, the plugin can and should use its ability to ellipsize overflowing text. I will look into creating a patch to the plugin to fix this.
As a side note, I am looking into possibly including a JS plugin that will allow users to dynamically control column sizes, which will hopefully solve this kind of issues for good.
#7 Updated by Tomer Brisker almost 2 years ago
- Tracker changed from Support to Bug
- Project changed from Foreman to Plugins
- Category deleted (
- Status changed from New to Ready For Testing
- Pull request https://github.com/GregSutcliffe/foreman_column_view/pull/18 added
I have submitted a PR to address issue #1 and converted this issue to the bug report for it.
Issue #2 should be fixed for 1.11 as mentioned above. (seems like the fix was too late to make the cut for 1.10)
As for dynamically resizing columns, this requires a bit of work and will be tracked in #1403.
#8 Updated by Tomer Brisker 11 months ago
- Project changed from Plugins to Foreman
- Category set to Web Interface
- Pull request deleted (
Looks like this will need a minor change to core to get working, moving back to Foreman core for that fix to be picked up.