Project

General

Profile

Actions

Bug #12166

closed

Progress bar "99%" lasts for a large chunk of the installation time

Added by Stephen Benjamin over 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

I'm not sure how difficult it would be to fix this, but for both foreman and katello installers the "99%" mark lasts quite a long time. For Katello, it's at least as long as the rest of the install.


Related issues 1 (0 open1 closed)

Has duplicate Kafo - Bug #14753: Last 5% of fusor-installer feels like it takes almost as long as 0 - 95%Duplicate04/21/2016Actions
Actions #1

Updated by Marek Hulán over 8 years ago

I think it got worse with newer versions of puppet, we hardcode resource names that we count so they might have just added some more? If you're interested, the code is here https://github.com/theforeman/kafo/blob/master/modules/kafo_configure/lib/puppet/parser/functions/add_progress.rb#L13

Actions #2

Updated by Dominic Cleal almost 8 years ago

  • Has duplicate Bug #14753: Last 5% of fusor-installer feels like it takes almost as long as 0 - 95% added
Actions #3

Updated by Dominic Cleal almost 8 years ago

There seem to be multiple causes of this:

1) Defines are double counted during the run as their status is logged twice, perhaps because they contain other resources. This should be easy to de-duplicate.

2) Concat 2.x uses a technique to add file resources to the catalog after we've counted them, so the additional resources are seen during the run but aren't in the total, causing over-counting.

3) File (directory) resources with recurse => true and purge => true generate one more resource if the dir contains a file that will be removed.

4) File (directory) resources with recurse => true and purge => true generate extra resources for every file that will be removed.

Actions #4

Updated by Dominic Cleal almost 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal
Actions #5

Updated by The Foreman Bot almost 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/kafo/pull/154 added
Actions #6

Updated by Dominic Cleal almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF