Project

General

Profile

Actions

Refactor #12179

closed

String extraction in host_inherited_params is wrong

Added by Ori Rabin over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Fixed in Releases:
Found in Releases:

Description

For managed hosts in host_inherited_params n_() is used to try and extract a string that isn't listed explicitly:
https://github.com/theforeman/foreman/blob/c1755e07/app/models/host/managed.rb#L453

This should be fixed to correctly extract all options for source.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #11763: Host API does not return all parameters (e.g. from locations, et al.)ClosedShlomi Zadok09/10/2015Actions
Actions #1

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #11763: Host API does not return all parameters (e.g. from locations, et al.) added
Actions #2

Updated by Dominic Cleal over 8 years ago

  • Description updated (diff)
  • translation missing: en.field_release set to 63

Setting for 1.10.0, as it's a regression.

Actions #3

Updated by Ori Rabin over 8 years ago

  • Status changed from New to Assigned
Actions #4

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee set to Ori Rabin
  • Pull request https://github.com/theforeman/foreman/pull/2946 added
Actions #5

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release changed from 63 to 104
Actions #6

Updated by Ori Rabin over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2948 added
Actions #8

Updated by Dominic Cleal about 8 years ago

  • translation missing: en.field_release changed from 104 to 71

Refactoring in patch is too risky, moving.

Actions

Also available in: Atom PDF