Refactor #13593: Preload assets before sprockets - Discovery - Foreman

Actions

Copy link

Refactor #13593

closed

Preload assets before sprockets

Added by Daniel Lobato Garcia almost 9 years ago. Updated almost 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Daniel Lobato Garcia

Category:

Discovery plugin

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_discovery/pull/247

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Currently Foreman core has an initializer (assets_paths) that takes care of finding the Discovery assets in the engine and load them before sprockets is loaded. This is happening because sprockets tries to load the assets before they are defined (:after => finisher_hook is too late).

Just changing it to :before finisher_hook is enough to make it load assets before then and the deprecation error will go away.