Bug #13828: CVE-2016-2100 - unprivileged user can see private bookmarks in Administer -> Bookmarks - Foreman

Actions

Copy link

Bug #13828

closed

CVE-2016-2100 - unprivileged user can see private bookmarks in Administer -> Bookmarks

Added by Ohad Levy over 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tom Caspy

Category:

Security

Target version:

1.10.3

Difficulty:

Triaged:

Bugzilla link:

1192414

Pull request:

https://github.com/theforeman/foreman/pull/3221

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1192414
Description of problem:
Unprivileged user can see Administer -> Bookmarks

How reproducible:
always

Steps to Reproduce:
1. Login with admin user
2. Switch to "Any context" and create user without any location, org and role
3. Logout with admin user and login with newly created user

Actual results:
The unprivileged user can access Administer -> Bookmarks. He can not get details about these bookmarks, details about these bookmarks, but see them.

Files

Screen Shot 2016-02-22 at 3.50.23 PM.png

View Screen Shot 2016-02-22 at 3.50.23 PM.png

13.7 KB

Tom Caspy, 02/22/2016 08:51 AM

Actions

Copy link

Updated by Ohad Levy over 8 years ago

I would expect bookmark listing to display my_bookmarks by default, similar to how the bookmark dropdown works.

Actions

Copy link

Updated by Ohad Levy over 8 years ago

Description updated (diff)

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Subject changed from unprivileged user can see Administer -> Bookmarks to unprivileged user can see private bookmarks in Administer -> Bookmarks
Category set to Security
Assignee deleted (~~Tom Caspy~~)

I think you specifically mean other user's private bookmarks are visible, so updated. The page and public bookmarks should be accessible to any user.

Please report security issues first to foreman-security, don't just file them in Redmine. See http://theforeman.org/security.html and https://groups.google.com/forum/#!msg/foreman-dev/noN-XJ1qXgU/vYFPVYLQDQAJ for more information. I will forward and start the CVE process myself.

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

There are further related issues with bookmarks, mostly coming from resource_base not being adequately defined:

UI edit action can render a form for a private bookmark by ID, if the user has edit_permission.
API index and get responses also shows private bookmarks from other users
update and destroy actions of both the UI and API are not scoped to bookmarks that the user should have access to update, so they can supply an ID for a private bookmark of another user, the resource is found and updated. User needs edit/destroy_bookmarks permission for this.

I've requested a CVE for this issue, we'll address it in the next release(s) following a patch being written.

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Subject changed from unprivileged user can see private bookmarks in Administer -> Bookmarks to CVE-2015-7582 - unprivileged user can see private bookmarks in Administer -> Bookmarks

CVE-2015-7582 has been assigned. Please include the number in the commit message.

Actions

Copy link

Updated by Tom Caspy over 8 years ago

File Screen Shot 2016-02-22 at 3.50.23 PM.png Screen Shot 2016-02-22 at 3.50.23 PM.png added

tried reproducing with unpriviliged user, failed.

Actions

Copy link

Updated by Tom Caspy over 8 years ago

but I can see all the hosts in the system, can't edit them. is that supposed to happen?

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Depends on the permissions assigned to your "Anonymous" role, which is a minimum set applied to all users.

The default changed some time ago and view_hosts was removed. view_bookmarks is assigned by default, so ensure yours matches the default seed (db/seeds.d/03-roles.rb).

Actions

Copy link

Updated by The Foreman Bot over 8 years ago

Status changed from New to Ready For Testing
Assignee set to Tom Caspy
Pull request https://github.com/theforeman/foreman/pull/3217 added

Actions

Copy link

#10

Updated by Dominic Cleal over 8 years ago

Subject changed from CVE-2015-7582 - unprivileged user can see private bookmarks in Administer -> Bookmarks to CVE-2016-2100 - unprivileged user can see private bookmarks in Administer -> Bookmarks

The CVE identifier should have been assigned from a 2016 block, so it's now CVE-2016-2100.

Actions

Copy link

#11