Bug #13968

Show errors when creating proxy even if /features returns an array

Added by Daniel Lobato Garcia over 1 year ago. Updated about 1 year ago.

Status:Closed
Priority:Normal
Assigned To:Shlomi Zadok
Category:Smart proxies
Target version:Team Marek Iteration 4
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3895, https://github.com/Katello/katello/pull/6377, https://github.com/theforeman/foreman/pull/3946
Story points-
Velocity based estimate-
Release1.14.0Release relationshipAuto

Description

When using an old version of Foreman, say '1.10' against a newer version of the proxy, say one that contains the 'logs' feature, the /features call will return an array ['logs'].
If you try to add a smart-proxy that only has this feature, the check we make `reply.is_a?(Array) and reply.any?` is not enough. We should verify we have the features in the db.

Currently the problem is:

- I try to add new smart-proxy with features ['logs'] to old foreman without this feature.
- Submit, it won't save. But it won't throw any error either.

We should display an error and say 'the features in this proxy are not recognized by foreman'.


Related issues

Duplicated by Salt - Feature #14669: Show something like "No supported features available on p... Duplicate 04/15/2016

Associated revisions

Revision 61802878
Added by Shlomi Zadok about 1 year ago

Fixes #13968 - Add error when no known proxy features found

Revision 7b9aa630
Added by Dominic Cleal about 1 year ago

refs #13968 - use existing feature to ensure reliable comparison

Feature.name_map may have returned either the new factory-based feature
or the existing fixture-based feature for the name 'TFTP', causing
intermittent failures.

History

#1 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3270 added

#2 Updated by Dominic Cleal over 1 year ago

  • Duplicated by Feature #14669: Show something like "No supported features available on proxy" instead of quietly do nothing and just write in log "Failed to save" added

#3 Updated by Dominic Cleal about 1 year ago

  • Status changed from Ready For Testing to New
  • Assigned To deleted (Daniel Lobato Garcia)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3270)

PR closed due to inactivity, but the bug is probably still valid.

#4 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Shlomi Zadok
  • Pull request https://github.com/theforeman/foreman/pull/3895 added

#5 Updated by Shlomi Zadok about 1 year ago

  • Target version set to Team Marek Iteration 3

#6 Updated by Marek Hulán about 1 year ago

  • Target version changed from Team Marek Iteration 3 to Team Marek Iteration 4

#7 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/Katello/katello/pull/6377 added

#8 Updated by Shlomi Zadok about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Dominic Cleal about 1 year ago

  • Release set to 1.14.0

#10 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/3946 added

Also available in: Atom PDF